Mask table fix #531
Mask table fix #531
Conversation
The most recent NCAR -> GFDL merge created an error (courtesy of myself) which left the CFC concentration units in the post_data call, even though these are now handled at registration. This patch restores this expression and removes the unit conversion from post_data.
- Without this, if part of your OBC is filled with land mask and if that land mask contains a masked out tile, you will generate a NaN from the phase speed calculation where h is negative in the halo neighbor of that masked tile.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #531 +/- ##
============================================
+ Coverage 37.49% 37.55% +0.06%
============================================
Files 271 271
Lines 79533 79401 -132
Branches 14816 14792 -24
============================================
- Hits 29819 29818 -1
+ Misses 44175 44043 -132
- Partials 5539 5540 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The changes to MOM_open_boundary here seem sensible enough and are well explained in the discussion.
I don't understand why the MOM_CFC_cap fix is showing up in this PR. It is correct, but I would think that it should appear in a separate PR to MOM6. @marshallward, do you understand how or why the MOM_CFC_cap fix is here?
I would be happy to approve this once we understand whether we should be accepting the MOM_CFC_cap fix as a part of this PR.
|
Sorry, can you pull it out? |
|
@Hallberg-NOAA That commit went to the GFDL->main candidate branch. We need to remove it from this PR. |
|
@kshedstrom Not easily, but I can remove it if I do a command-line merge. Seems like this has otherwise been approved so I will do that. |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21708 ✔️ (Parameters are not out of date, despite warnings). |
|
This has been merged to dev/gfdl. The hashes have changed, so I have to manually close this PR. |
No description provided.