Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Rescale some sea-surface height variables to [Z] #39

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

Hallberg-NOAA
Copy link
Member

Rescaled the units of four internal sea surface height or related variables in
MOM.F90 and three sea surface height arguments to post_surface_dyn_diags and
post_surface_thermo_diags from [m] to [Z ~> m]. Also added a few comments
describing variables in MOM_diagnostics.F90. All answers, diagnostics, and
output are bitwise identical.

  Rescaled the units of four internal sea surface height or related variables in
MOM.F90 and three sea surface height arguments to post_surface_dyn_diags and
post_surface_thermo_diags from [m] to [Z ~> m].  Also added a few comments
describing variables in MOM_diagnostics.F90.  All answers, diagnostics, and
output are bitwise identical.
@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #39 (eb81922) into dev/gfdl (6feadd0) will increase coverage by 0.00%.
The diff coverage is 68.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #39   +/-   ##
=========================================
  Coverage     28.96%   28.97%           
=========================================
  Files           240      240           
  Lines         71175    71185   +10     
=========================================
+ Hits          20619    20623    +4     
- Misses        50556    50562    +6     
Impacted Files Coverage Δ
src/core/MOM.F90 58.71% <41.66%> (-0.21%) ⬇️
src/diagnostics/MOM_diagnostics.F90 75.53% <92.30%> (+0.06%) ⬆️
src/core/MOM_interface_heights.F90 38.37% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6feadd0...eb81922. Read the comment docs.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14353 ✔️

@marshallward marshallward merged commit bbb9753 into NOAA-GFDL:dev/gfdl Dec 14, 2021
@Hallberg-NOAA Hallberg-NOAA added documentation Improvements or additions to documentation refactor Code cleanup with no changes in functionality or results labels Feb 1, 2022
@Hallberg-NOAA Hallberg-NOAA deleted the rescale_SSH branch March 25, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation refactor Code cleanup with no changes in functionality or results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants