Bugfix: cpu clock sync error #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an error in the `sync` flag of the cpu clocks. Previously, we would set the sync bit of a flag based on the presence of sync, rather than testing if the value was true. This would cause potential hangs in any clock that set `sync`, including `.false.`. This patch correctly replaces the single `ibset` call with an if-block to either `ibset` or `ibclr`.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #27 +/- ##
============================================
- Coverage 29.00% 29.00% -0.01%
============================================
Files 240 240
Lines 71235 71237 +2
============================================
Hits 20665 20665
- Misses 50570 50572 +2
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
I agree that these changes do correct a bug in the implementation of the sync option to the two clock_id() routines. They have passed both TC testing and pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14333.
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an error in the
syncflag of the cpu clocks.Previously, we would set the sync bit of a flag based on the presence of
sync, rather than testing if the value was true. This would cause
potential hangs in any clock that set
sync, including.false..This patch correctly replaces the single
ibsetcall with an if-blockto either
ibsetoribclr.