+Rescale fluxes%net_mass_src and other diagnostics #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retaing dimensional rescaling for several diagnostics: - Apply dimensional rescaling of fluxes%net_mass_src to and the net_mass_src argument to get_net_mass_forcing to [R Z T-1]. - Rescaled the patm argument of convert_state_to_ocean_type to [R L2 T-2] and press_to_Z to [Z T2 R-1 L-2]; these are not actually exercised yet, so this has a very limited scope, although three other local variables were also dimensionally rescaled. - Revised the line breaks in two calls to register_restart to place the units and conversion factos on the same line, following a widespread code pattern. - Used the scale argument in calls to global_area_integral or global_area_mean for 6 diagnostics, so that 3 other primary variables can be calculated in scaled units and rescaled via factors specified in the register_restart calls, following a widespread code pattern. All answers and output are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #23 +/- ##
============================================
- Coverage 29.08% 29.07% -0.01%
============================================
Files 240 240
Lines 71298 71289 -9
============================================
- Hits 20735 20728 -7
+ Misses 50563 50561 -2
Continue to review full report at Codecov.
|
|
gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/14294 ✔️ |
marshallward
approved these changes
Dec 8, 2021
This was referenced Jan 29, 2022
Hallberg-NOAA
added
the
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retaing dimensional rescaling for several diagnostics:
argument to get_net_mass_forcing to [R Z T-1].
and press_to_Z to [Z T2 R-1 L-2]; these are not actually exercised yet,
so this has a very limited scope, although three other local variables were
also dimensionally rescaled.
and conversion factos on the same line, following a widespread code pattern.
for 6 diagnostics, so that 3 other primary variables can be calculated in
scaled units and rescaled via factors specified in the register_restart calls,
following a widespread code pattern.
All answers and output are bitwise identical.