Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A welcome message #222

Closed
wants to merge 1 commit into from
Closed

Conversation

marshallward
Copy link
Member

This is a welcome message to welcome new people.

This is a welcome message to welcome new people.
@marshallward
Copy link
Member Author

@Hallberg-NOAA csn you please review?

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposed change is a terrible idea, in that will lead to numerous messages, one from each PE, and it violates MOM6 standards for the use of standardized I/O protocols. If we really wanted to keep this message, the print statement should be replaced by a call to call MOM_mesg(),

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #222 (f5a2460) into dev/gfdl (a907bfd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           dev/gfdl     #222   +/-   ##
=========================================
  Coverage     37.11%   37.11%           
=========================================
  Files           263      263           
  Lines         73062    73063    +1     
  Branches      13644    13644           
=========================================
+ Hits          27114    27115    +1     
  Misses        40929    40929           
  Partials       5019     5019           
Impacted Files Coverage Δ
src/core/MOM.F90 50.68% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@marshallward marshallward deleted the my_feature branch November 8, 2022 23:02
marshallward pushed a commit that referenced this pull request Apr 4, 2023
add ML tracer to ideal age module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants