Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*+Correct oblique OBC restarts #219

Merged
merged 5 commits into from
Oct 25, 2022
Merged

*+Correct oblique OBC restarts #219

merged 5 commits into from
Oct 25, 2022

Commits on Oct 21, 2022

  1. *+Corrected some oblique OBC restarts 

      Added separate restart variables for some of the oblique OBC restart variables
at north-south or east-west faces.  Before this fix, some of the full 3-d arrays
for restarts were being overwritten for oblique OBC segments that join at
adjacent corners on the north-east side of tracer points, as is noted in
github.com/NOAA-GFDL/issues/208.  The discussion surrounding this issue
confirms that there are cases using oblique OBCs (like some North-West Atlantic
cases) that do not past the restart reproducibility tests.  Some halo updates
were also corrected, in accordance with the introduction of these new variables
and their proper staggering locations.  In a number of places, the proper
case-sensitive horizontal indexing convention, as described in
github.com/NOAA-GFDL/MOM6/wiki/Code-style-guide#soft-case-convention, is now
being used.  This commit also corrected the comments describing a number of the
variables in the OBC_segment_type to make it clearer where they are discretized.

  This changes the names of oblique OBC-related variables in the restart files,
but since the previous version did not reproduce across restarts, there does not
seem to be any point in retaining those incorrect answers.  All answers in the
MOM6-examples test suite are bitwise identical, but this will change (fix)
solutions with oblique OBCs and OBC_RAD_VEL_WT < 1.
    @Hallberg-NOAA
    Hallberg-NOAA committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    ca0cdb3 View commit details
    Browse the repository at this point in the history

  2. +Attempt to fix an imperfect restart issue.

    @kshedstrom @Hallberg-NOAA
    kshedstrom authored and Hallberg-NOAA committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    5fe02e0 View commit details
    Browse the repository at this point in the history

  3. *+Added G%OBCmaskCu and G%OBCmaskCv 

      Added two new arrays (OBCmaskCu and OBCmaskCv) to the ocean_grid_type and
dyn_horgrid_type to mask out values over land or at open boundary condition
points.  Without open boundary conditions, these arrays are identical to
mask2dCu and mask2dCv.  These arrays are used in some of the lateral
parameterization modules to zero out certain gradient-dependent fluxes at open
boundary points.  With these changes, the Bering test case solutions no longer
exhibit any dependence on whether DEBUG_OBC is true or false or the value of
OBC_SILLY_THICK, so this commit should help to address some of the issues
discussed in github.com/NOAA-GFDL/issues/208.  All answers are bitwise
identical in the MOM6-examples test cases, but they change for some other tests
that use open boundary conditions more extensively, and there are new arrays in
some transparent types.
    @Hallberg-NOAA
    Hallberg-NOAA committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    2bd92ba View commit details
    Browse the repository at this point in the history

  4. +Eliminate unused OBC arguments 

      Eliminated OBC arguments that are no longer used by three internal routines in
MOM_lateral_mixing_coeffs.  All answers are bitwise identical.
    @Hallberg-NOAA
    Hallberg-NOAA committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    70a9e15 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev/gfdl' into oblique_OBC_restart_fix

    @marshallward
    marshallward authored Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d96e5ce View commit details
    Browse the repository at this point in the history