Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Codecov uploader update #21

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

marshallward
Copy link
Member

This patches updates the codecov uploader to the new version, replacing
the bash uploader to be phased out in 2022.

The uploader URL is now a configuable variable, and the coverage scripts
have been modified to accommodate changes in the uploader.

Under this new uploader, the coverage reports must be generated locally,
rather than relying on the bash script to call gcov. So we now generate
these scripts based on the *.gcda output.

This patches updates the codecov uploader to the new version, replacing
the bash uploader to be phased out in 2022.

The uploader URL is now a configuable variable, and the coverage scripts
have been modified to accommodate changes in the uploader.

Under this new uploader, the coverage reports must be generated locally,
rather than relying on the bash script to call gcov.  So we now generate
these scripts based on the *.gcda output.
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #21 (0eb5378) into dev/gfdl (ad35e4a) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0eb5378 differs from pull request most recent head 7d80abc. Consider uploading reports for the commit 7d80abc to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl      #21   +/-   ##
=========================================
  Coverage     29.17%   29.17%           
=========================================
  Files           240      240           
  Lines         71493    71491    -2     
=========================================
  Hits          20856    20856           
+ Misses        50637    50635    -2     
Impacted Files Coverage Δ
src/framework/MOM_domains.F90 51.72% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad35e4a...7d80abc. Read the comment docs.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look sensible to me, and this has passed the TC testing. In this particular case there is no point in running the pipeline tests on these changes, so the TC testing alone will suffice.

@Hallberg-NOAA Hallberg-NOAA merged commit 7e1474e into NOAA-GFDL:dev/gfdl Dec 6, 2021
@marshallward marshallward deleted the new_codecov_uploader branch March 8, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants