Fix ALE sponge diagnostics #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #188 +/- ##
============================================
- Coverage 37.22% 37.22% -0.01%
============================================
Files 261 261
Lines 72319 72334 +15
Branches 13533 13533
============================================
+ Hits 26921 26925 +4
- Misses 40407 40417 +10
- Partials 4991 4992 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I don't see much structure to these commits, so I will do a squash-merge. |
|
@WenhaoChen89 I made a minor change to this PR fixing a style issue (removal of spaces around operators inside function arguments). (I admit that I also just wanted to try the in-browser editor and see if it would work 😅) |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16468 ✔️ |
marshallward
approved these changes
Aug 19, 2022
|
Gaea regression (v2): https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16476 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the ALE sponge diagnostics.
In the module MOM_ALE_sponge, the ALE sponge diagnostics of tracers is initialized with a fixed order, i.e., the first one is 'temperature' and the second one is 'salinity' (line 604-609 in subroutine init_ALE_sponge_diags). However, when the data is posted for the diagnostics, it follows the order of how tracer sponges are set up (line 961-997 in subroutine apply_ALE_sponge).
The fix includes: