(*)Internal thickness variable unit correction #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the internal units of several internal thickness variables in ePBL_column and of some temporary diagnostics in MOM_bulk_mixed_layer from [Z] to [H] to reduce the number of rescaling factors that are being applied outside of the conversion factors when diagnostics are registered. All answers and output are bitwise identical in the MOM6-examples test suite, although in some cases where ePBL is used with a non-Boussinesq model, there may be answers at roundoff. I wanted to make this change now before any such models exist.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #139 +/- ##
=========================================
Coverage 34.26% 34.26%
=========================================
Files 257 257
Lines 69742 69743 +1
Branches 12913 12913
=========================================
+ Hits 23896 23897 +1
Misses 41372 41372
Partials 4474 4474
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15759 ✔️ |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15919 ✔️ |
marshallward
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the internal units of several internal thickness variables in
ePBL_column and of some temporary diagnostics in MOM_bulk_mixed_layer from [Z]
to [H] to reduce the number of rescaling factors that are being applied outside
of the conversion factors when diagnostics are registered. All answers and
output are bitwise identical in the MOM6-examples test suite, although in some
cases where ePBL is used with a non-Boussinesq model, there may be answers at
roundoff. I wanted to make this change now before any such models exist.