(*)Corrected OBC restart scaling bugs #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected two bugs in the code handling the unscaling of tracers in east-west open boundary segments. Both changes bring the east-west code into (closer?) agreement with the north-south code, and it might explain some recent reports of strange behavior. However, the fact that the existing MOM6-examples pipeline tests do not detect this bug reveals a clear shortcoming in the suite of test cases with OBCs that are currently being testing with MOM6 code changes. These bugs were introduced to dev/gfdl on May 22, 2022 (one week before this fix) as a part of PR# 122 (NOAA-GFDL#122).
Hallberg-NOAA
added
bug
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #132 +/- ##
============================================
- Coverage 33.45% 33.45% -0.01%
============================================
Files 262 262
Lines 71384 71385 +1
Branches 13323 13323
============================================
Hits 23884 23884
- Misses 43028 43029 +1
Partials 4472 4472
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15639 ✔️ |
marshallward
approved these changes
May 29, 2022
kshedstrom
pushed a commit
to ESMG/MOM6
that referenced
this pull request
May 1, 2024
…in-20240401 update to MOM6 main repo 20240401 commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected two bugs in the code handling the unscaling of tracers in east-west
open boundary segments. Both changes bring the east-west code into (closer?)
agreement with the north-south code, and it might explain some recent reports of
strange behavior. However, the fact that the existing MOM6-examples pipeline
tests do not detect this bug reveals a clear shortcoming in the suite of test
cases with OBCs that are currently being testing with MOM6 code changes. These
bugs were introduced to dev/gfdl on May 22, 2022 (one week before this fix) as a
part of PR# 122 (#122).