Data override updates and bugfixes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
previously approved these changes
Mar 10, 2022
GFDL-Eric
reviewed
Mar 10, 2022
| call mpp_global_field(Atm%Domain, Atm%lon_bnd, glon_bnd, position=CORNER) | ||
| call mpp_global_field(Atm%Domain, Atm%lat_bnd, glat_bnd, position=CORNER) | ||
|
|
||
| if (.NOT.Atm%bounded_domain) call data_override_init (Atm_domain_in = Atm%domain) |
There was a problem hiding this comment.
Do we know what the logic behind excluding bounded_domain is here? I know Lauren opened an issue a while ago relating to some unsupported regional model behavior in data override, but that could be unrelated. I would assume there wouldn't be a data_table if the bounded_domain existed because it would never get called in this scenario, but I don't know that for sure.
There was a problem hiding this comment.
@GFDL-Eric - this is a topic I'll be bringing up for FMS dev as a whole and data_override in particular. I'll try to make it a topic for the next group meeting.
GFDL-Eric
previously approved these changes
Mar 10, 2022
laurenchilutti
previously approved these changes
Mar 10, 2022
thomas-robinson
approved these changes
Mar 31, 2022
laurenchilutti
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes grid code and variables from SHiELD/coupler_main and fixes data_override_init
Removes outdated logic in simple/coupler_main for data_override_init parsing
Relies upon FMS PR #933