9 - coupler_chksum_obj, coupler_atmos_tracer_driver_gather_data, coupler_sfc_boundary_layer #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
changed the title
full/full_coupler_mod.F90
Outdated
| !! The members of this type point to the model components | ||
| type coupler_chksum_type | ||
| private | ||
| type(coupler_components_type) :: components |
There was a problem hiding this comment.
are these two of these? Should this point to coupler_components_obj?
There was a problem hiding this comment.
it has been changed to a pointer
full/full_coupler_mod.F90
Outdated
| !> Function set_component sets the requested component in the coupler_components_type object | ||
| !! Users are required to provide the component to be set as an input argument. For example, | ||
| !! coupler_components_obj%get_component(Atm) will set coupler_components_obj%Atm = Atm | ||
| subroutine set_component(this, set_this_component ) |
There was a problem hiding this comment.
I would be shocked if this worked. I don't think these types all have overloaded =
There was a problem hiding this comment.
It has been removed.
uramirez8707
approved these changes
Jun 17, 2024
thomas-robinson
approved these changes
Jun 17, 2024
rem1776
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
Coupler_chksum_objof typecoupler_chksum_typehas been added and is used for input argument to coupler subroutines that compute checksums if do_chksum = .True. The purpose of this object is to simplify coupler subroutine arguments list.coupler_atmos_tracer_driver_gather_dataandcoupler_sfc_boundary_layerhave been added.CHECKSUMS were only checked for the first timestep in run "CM4_piControl_C_2x0m15d_432x2a_2997x1o" and agree with those from main.