Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6 - coupler_unpack_ocean_ice_boundary, coupler_exchange_slow/fast_ice, coupler_set_ice_surface_fields #118

Merged
merged 123 commits into from
Jun 4, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented May 23, 2024

In this PR, the following coupler subroutines are defined and are called in full coupler_main

  1. coupler_unpack_ocean_ice_boundary,
  2. coupler_exchange_slow_to_fast_ice,
  3. coupler_exchange_fast_to_slow_ice, and
  4. coupler_set_ice_surface_fields

Subroutine coupler_unpack_ocean_ice_boundary calls both flux_ocean_to_ice_finish and unpack_ocean_ice_boundary.

Subroutine coupler_exchange_fast_to_slow_ice contains an optional argument to set the current pelist to Ice%pelist. This subroutine is called twice in coupler_main where only the second call requires the setting of the current pelist.

@mlee03 mlee03 marked this pull request as ready for review May 30, 2024 16:19
Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more documentatiion for the subroutine descriptions. It will be helpful in any of the automated documentation generation to have more details about the subroutines

full/full_coupler_mod.F90 Outdated Show resolved Hide resolved
@rem1776 rem1776 merged commit afb305e into NOAA-GFDL:main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants