-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6 - coupler_unpack_ocean_ice_boundary, coupler_exchange_slow/fast_ice, coupler_set_ice_surface_fields #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upler_fast_slow_ice
…upler_fast_slow_ice
thomas-robinson
requested changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some more documentatiion for the subroutine descriptions. It will be helpful in any of the automated documentation generation to have more details about the subroutines
mlee03
force-pushed
the
coupler_fast_slow_ice
branch
from
June 4, 2024 13:28
e5638d9
to
cddc633
Compare
thomas-robinson
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the following coupler subroutines are defined and are called in full coupler_main
coupler_unpack_ocean_ice_boundary
,coupler_exchange_slow_to_fast_ice
,coupler_exchange_fast_to_slow_ice
, andSubroutine
coupler_unpack_ocean_ice_boundary
calls bothflux_ocean_to_ice_finish
andunpack_ocean_ice_boundary
.Subroutine
coupler_exchange_fast_to_slow_ice
contains an optional argument to set the current pelist to Ice%pelist. This subroutine is called twice in coupler_main where only the second call requires the setting of the current pelist.