#5 - coupler_flux_ocean_to_ice and coupler_flux_ice_to_ocean #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
changed the title
mlee03
commented
May 31, 2024
| @@ -371,7 +371,7 @@ program coupler_main | |||
| character(len=32) :: timestamp | |||
|
|
|||
| type(coupler_clock_type) :: coupler_clocks | |||
|
|
|||
There was a problem hiding this comment.
I have no idea what's going on with these trailing spaces
thomas-robinson
requested changes
May 31, 2024
thomas-robinson
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
coupler_flux_ocean_to_iceandcoupler_flux_ice_to_oceanhave been defined and have been used to replace sections of coupler_main that calls flux_ocean_to_ice and flux_ice_to_ocean subroutines .Subroutine
coupler_flux_ice_to_oceanis called twice in coupler_main and contains the option to set slow_ice_ocean_pelist as the current pelist for the following reason: at the top of the outer loop, current pelist is set to slow_ice_ocean_pelist incoupler_flux_ocean_to_ice. Thus, the pelist is already set to the correct one whencoupler_flux_ice_to_oceanis called immediately afterwords. However, the current pelist is not set to slow_ice_ocean_pelist whencoupler_flux_ice_to_oceanis called at the bottom of the outer loop. The optional argument is not specified in the first call and is set in the second call.Pending: all the "if(pe)" statements remain unchanged in coupler_main in case MPI parallelization details benefit the users.