Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running SHiELD with a Gregorian calendar #105

Merged

Conversation

spencerkclark
Copy link
Member

This PR fixes #103 by adding 'GREGORIAN' as an option in the select case statement for inferring the calendar_type in SHiELD's coupler_main.F90. I tested this in a short simulation (including a restart) and things ran without a problem, so this indeed appears as simple as @bensonr suggested.

cc: @lharris4

@bensonr bensonr self-requested a review March 8, 2024 17:52
@bensonr
Copy link
Contributor

bensonr commented Mar 8, 2024

@spencerkclark - if you want to use an existing restart, you will need to modify coupler.res (ascii file in INPUT/) and might need to change the value of coupler_nml::calendar. There is a hierarchy of what takes precedence and I believe coupler.res wins all battles.

@spencerkclark
Copy link
Member Author

Thanks @bensonr and @lharris4!

if you want to use an existing restart, you will need to modify coupler.res (ascii file in INPUT/) and might need to change the value of coupler_nml::calendar. There is a hierarchy of what takes precedence and I believe coupler.res wins all battles.

Indeed it makes sense we can still hack that if needed.

@bensonr bensonr merged commit b7d29da into NOAA-GFDL:main Mar 8, 2024
2 checks passed
@spencerkclark spencerkclark deleted the enable-gregorian-calendar-SHiELD branch March 8, 2024 18:39
@thomas-robinson
Copy link
Member

@rem1776 @Scitech777 Is there a current alpha tag for the coupler? Was the coupler tagged with the latest alpha testing tag?

@rem1776
Copy link
Contributor

rem1776 commented Mar 8, 2024

@thomas-robinson Yeah it was tagged already, I can bump it up to this commit if we want this included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should SHiELD be using a Gregorian calendar?
5 participants