Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use_mpp_io from diag manager #940

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

thomas-robinson
Copy link
Member

@thomas-robinson thomas-robinson commented Mar 21, 2022

Description
Removes the variable use_mpp_io from the diag manager.

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@thomas-robinson thomas-robinson changed the base branch from main to dmUpdate March 21, 2022 16:34
@thomas-robinson thomas-robinson marked this pull request as draft March 21, 2022 16:34
Copy link
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I can see.

@GFDL-Eric
Copy link
Contributor

@thomas-robinson This doesn't actually have any duplication from #928 since I wasn't sure whether or not to get rid of the use_mpp_io namelist flag (if anyone still uses it). Of course, I could incorporate these changes into #928 if we feel like they should go together.

@thomas-robinson
Copy link
Member Author

Thanks @GFDL-Eric I think you should keep #928 as is, and let this be part of the diag manager modernization. Then we can remove the rest of use_mpp_io in the "2022.05" end of year release.

@GFDL-Eric
Copy link
Contributor

@thomas-robinson sounds good!

@thomas-robinson thomas-robinson marked this pull request as ready for review March 23, 2022 18:51
@thomas-robinson thomas-robinson merged commit 5c10ab8 into NOAA-GFDL:dmUpdate Mar 23, 2022
@thomas-robinson thomas-robinson deleted the dmInit branch August 17, 2022 12:49
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants