Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of mpp::get_peset function #1275

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

bensonr
Copy link
Contributor

@bensonr bensonr commented Jul 5, 2023

Description
Minor cleanup and performance enhancements for the mpp::get_peset function

Fixes #1273

How Has This Been Tested?
FMS CI was tested on an AMD-based dev box and Gaea. Additional testing was performed with a test code that calls mpp_broadcast with an optional undefined pelist which will ensure code coverage for the modified sections of get_peset.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 added this to the 2023.03 milestone Aug 10, 2023
@thomas-robinson
Copy link
Member

@rem1776 make sure this is included in 2023.03

@rem1776 rem1776 merged commit a46bd94 into NOAA-GFDL:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup of mpp::get_peset function
3 participants