Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call monin_obukhov_stable_mix from stable_mix_1d #1268

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

J-Lentz
Copy link
Contributor

@J-Lentz J-Lentz commented Jun 29, 2023

Restructure the subroutines in the stable_mix interface of monin_obukhov_mod so that stable_mix_1d calls monin_obukhov_stable_mix, which is the underlying implementation. stable_mix_2d and stable_mix_3d now call stable_mix_1d on 1D slices of the data.

This change is needed for the mixed precision updates to monin_obukhov_mod because, with monin_obukhov_stable_mix being converted from a subroutine to an interface, arrays with mismatched ranks can no longer be passed directly.

How Has This Been Tested?
Builds with Intel on the AMD box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Restructure the subroutines in the `stable_mix` interface of `monin_obukhov_mod`
so that `stable_mix_1d` calls `monin_obukhov_stable_mix`, which is the
underlying implementation. `stable_mix_2d` and `stable_mix_3d` now call
`stable_mix_1d` on 1D slices of the data.
@rem1776 rem1776 merged commit 05337ea into NOAA-GFDL:main Jul 13, 2023
27 checks passed
ganganoaa pushed a commit to ganganoaa/FMS that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants