Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Convert FIMS concurrent example to testthat test or a vignette #528

Open
Bai-Li-NOAA opened this issue Nov 21, 2023 · 0 comments
Labels
kind: refactor Restructure code to improve the implementation of FIMS theme: code cleanup
Milestone

Comments

@Bai-Li-NOAA
Copy link
Contributor

Refactor request

Pull request #520 merged R scripts into the main branch to facilitate the closure of the feature branch related to issue #312. These scripts, part of the FIMS concurrent example, compare the performance of running FIMS using {Rmpi}, {processR}, and {snowfall}. Options for updating the scripts include

  • converting them into a test using the testthat framework or
  • creating a vignette comparing performance with {Rmpi}, {processR}, and {snowfall}.
@Bai-Li-NOAA Bai-Li-NOAA added status: triage_needed This is not approved for this milestone, do not work on it yet kind: refactor Restructure code to improve the implementation of FIMS labels Nov 21, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA added status: triage_needed This is not approved for this milestone, do not work on it yet and removed status: triage_needed This is not approved for this milestone, do not work on it yet labels Nov 21, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA added this to the 2 milestone Nov 21, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA removed their assignment Nov 21, 2023
@ChristineStawitz-NOAA ChristineStawitz-NOAA modified the milestones: 2, Parking lot Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: refactor Restructure code to improve the implementation of FIMS theme: code cleanup
Projects
None yet
Development

No branches or pull requests

2 participants