You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For information.hpp there are a lot of places that need errors to be logged that currently just have //log error comments showing where this is needed. The indentation is also off on lines 221-291 which need one less indent. @Andrea-Havron-NOAA has done a great job explaining the logic of this file in the vignette which was really helpful for our review. It may or may not make sense to add some of this explanation directly in the code as comments to help future developers understand what is being done and why without having to refer back to the vignette or manual.
The text was updated successfully, but these errors were encountered:
@kellijohnson-NOAA I pushed up new changes with basic logs for CreateModel() can you take a look and let me know if you think anything is missing or should be changed. Everything is going to FIMS_LOG for now, I think we need to figure out a larger plan for how to separate logs for different sections/needs and then we can modify this but not sure that is in the scope of this issue.
From @nathanvaughan-NOAA:
For information.hpp there are a lot of places that need errors to be logged that currently just have //log error comments showing where this is needed. The indentation is also off on lines 221-291 which need one less indent. @Andrea-Havron-NOAA has done a great job explaining the logic of this file in the vignette which was really helpful for our review. It may or may not make sense to add some of this explanation directly in the code as comments to help future developers understand what is being done and why without having to refer back to the vignette or manual.
The text was updated successfully, but these errors were encountered: