Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Find a file parser for C++ tests #391

Closed
1 of 3 tasks
Bai-Li-NOAA opened this issue Jul 6, 2023 · 0 comments · Fixed by #434 or #519
Closed
1 of 3 tasks

[Feature]: Find a file parser for C++ tests #391

Bai-Li-NOAA opened this issue Jul 6, 2023 · 0 comments · Fixed by #434 or #519
Labels
kind: feature New feature or request P2 mid-level priority
Milestone

Comments

@Bai-Li-NOAA
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently FIMS uses RapidJson for C++ integration tests and includes a copy of the RapidJson repo inside of FIMS. It would be good to review available options and figure out how to include another repo inside of FIMS.

Describe the solution you would like.

  • review available Json (or other file types) parsers/generators and select one for long term use
  • follow the best practice to include other projects/repos inside FIMS. For example, Git submodules can keep a Git repository as a subdirectory of another Git repository. This lets us clone another repository into your project and keep your commits separate.

Describe alternatives you have considered

Continue using RapidJson.

Statistical validity, if applicable

No response

Describe if this is needed for a management application

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Bai-Li-NOAA Bai-Li-NOAA added the status: triage_needed This is not approved for this milestone, do not work on it yet label Jul 6, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA removed the status: triage_needed This is not approved for this milestone, do not work on it yet label Jul 11, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA added this to the MQ milestone Jul 11, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA added the status: needs discussion Dialogue is needed before a decision can be made. label Jul 11, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA added the kind: feature New feature or request label Jul 11, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA added the P2 mid-level priority label Jul 18, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA removed the status: needs discussion Dialogue is needed before a decision can be made. label Aug 8, 2023
@msupernaw msupernaw linked a pull request Aug 9, 2023 that will close this issue
1 task
@Bai-Li-NOAA Bai-Li-NOAA linked a pull request Nov 9, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New feature or request P2 mid-level priority
Projects
No open projects
Status: Done
4 participants