Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source bash configurations #36

Merged
merged 4 commits into from
Jun 27, 2024
Merged

source bash configurations #36

merged 4 commits into from
Jun 27, 2024

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Jun 27, 2024

Description
This PR:

  • runs subprocess in a bash shell
  • allows the test_configuration tests to run on GH runner. They were previously disabled on GA

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • pynorms
  • pytests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.00%. Comparing base (5dad7dd) to head (239773c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage    48.23%   50.00%   +1.76%     
===========================================
  Files           18       18              
  Lines         1644     1646       +2     
  Branches       335      335              
===========================================
+ Hits           793      823      +30     
+ Misses         791      763      -28     
  Partials        60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small feat for now

@aerorahul aerorahul merged commit 1356acd into develop Jun 27, 2024
17 checks passed
@aerorahul aerorahul deleted the config_env_bash branch June 27, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants