Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLiteDB.Error.Excetption -> SQLiteDBError.Exception update #19

Merged

Conversation

TerrenceMcGuinness-NOAA
Copy link
Contributor

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Mar 8, 2024

Description

Needed to add SQLiteDBError to __init__.py to use SQLiteDBError.Exception over SQLiteDB.Error.Exception

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with working version of pr_list_database.py

  • pynorms
  • pytests

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.88%. Comparing base (a35ad18) to head (3e45109).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #19      +/-   ##
===========================================
- Coverage    50.91%   50.88%   -0.04%     
===========================================
  Files           16       16              
  Lines         1477     1476       -1     
  Branches       313      313              
===========================================
- Hits           752      751       -1     
  Misses         669      669              
  Partials        56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aerorahul aerorahul merged commit 942b90b into NOAA-EMC:develop Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants