Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose a couple of specific sqlite3 error codes to Class object #18

Merged

Conversation

TerrenceMcGuinness-NOAA
Copy link
Contributor

Description

We request adding a couple of key sqlite3 error codes to be exposed by the wxflow SQLiteDB Class so the user can specifically query for the error strings with then the are appropriately encountered for a reaction.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The re-action to using try block when a uniqueness was violated was appropriately observed in the driver code using the class.

  • pynorms
  • pytests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.91%. Comparing base (97159f7) to head (dc02772).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #18      +/-   ##
===========================================
+ Coverage    50.78%   50.91%   +0.13%     
===========================================
  Files           16       16              
  Lines         1473     1477       +4     
  Branches       313      313              
===========================================
+ Hits           748      752       +4     
  Misses         669      669              
  Partials        56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/wxflow/sqlitedb.py Outdated Show resolved Hide resolved
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
will merge when the tests and norms pass.

@TerrenceMcGuinness-NOAA
Copy link
Contributor Author

updated pynorms for spaces

@aerorahul aerorahul merged commit a35ad18 into NOAA-EMC:develop Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants