Satwnd and variable name-convention updates for jcb implementation in GDASApp #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-conventions: satwind->satwnd, qualityInformationWithoutForecast->qiWithoutForecast
CoryMartin-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
May 21, 2024
… GDASApp (#1119) Updates to file- and variable-name conventions in satellite wind assimilation for GDASApp end-to-end validation. The following name conventions have been changed: 1) `satwind` --> `satwnd`, this affects file-names and keeps the use of satwnd consistent across the entire GDASApp end-to-end validation system 2) `qualityInformationWithoutForecast` --> `qiWithoutForecast`, variable-name change to make QI variable compliant with JCSDA/ioda ObsSpace.yaml This PR is dependent on NOAA-EMC/jcb-gdas#7 for name-convention updates to QC YAMLs. No changes to UFO/GSI acceptance are detected in testing with the exception of a single-ob differences from (relatively old) prior tests. --------- Co-authored-by: Brett Hoover <bhoover@Orion-login-1.HPC.MsState.Edu>
danholdaway
approved these changes
May 21, 2024
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name-convention changes for satellite winds in GDASApp with jcb implementation:
satwind-->satwnd, this affects file-names and keeps the use ofsatwndconsistent across the entire GDASApp end-to-end validation systemqualityInformationWithoutForecast-->qiWithoutForecast, variable-name change to make QI variable compliant with JCSDA/ioda ObsSpace.yamlThis PR is submitted for NOAA-EMC/GDASApp#1119