Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCB-based obs+bias staging #31

Merged
merged 4 commits into from
Oct 9, 2024
Merged

JCB-based obs+bias staging #31

merged 4 commits into from
Oct 9, 2024

Conversation

DavidNew-NOAA
Copy link
Contributor

This PR is a companion to Global Workflow PR #2992 and GDASApp PR #1312.

It add observation and bias files staging templates required for the above Global Workflow PR.

@CoryMartin-NOAA
Copy link
Contributor

@DavidNew-NOAA @danholdaway this is a good opportunity to figure out why the JCB-GDAS CI times out after hours. It hangs and doesn't work properly and I don't know what is going on (we can force merge like I was doing in Dan's absence)

@RussTreadon-NOAA
Copy link
Contributor

@DavidNew-NOAA: As currently scripted all radiance bias correction files are in a single tarball. It sounds like aircraft bias correction will be a single file for all tail numbers. Is this correct, @CoryMartin-NOAA ?

@CoryMartin-NOAA
Copy link
Contributor

@RussTreadon-NOAA that is my understanding, yes

@DavidNew-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA @RussTreadon-NOAA If that's the case, should we put an entry in each the observation templates, under the obs_bias entry, something like tarball, that indicates the name of the tarball, rather than hardcoding it into the JCB bias staging template? See here for example:

@CoryMartin-NOAA
Copy link
Contributor

@DavidNew-NOAA that might interfere with the JEDI YAML readers?

@DavidNew-NOAA
Copy link
Contributor Author

@CoryMartin-NOAA See my latest commit. Also NOAA-EMC/GDASApp@29696c8 in my GDASApp PR. I think this is going to be the best way to do this.

@danholdaway
Copy link
Collaborator

I can put it on my list for next week to fix the CI. I don't have a lot of time this week with the ongoing sprint and don't want to hold things up.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 7717c0e into develop Oct 9, 2024
1 check failed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/jcb-obsbias branch October 9, 2024 19:30
CoryMartin-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Oct 15, 2024
This PR is a companion to Global-Workflow PR
[#2992](NOAA-EMC/global-workflow#2992) and
JCB-GDAS PR [#31](NOAA-EMC/jcb-gdas#31).

It adds two parameters required for the above Global-Workflow PR to the
JCB base YAML for the atmosphere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants