-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to ROTDIR/COMIN definitions related to compath.py and new GLDAS tag #565
Updates to ROTDIR/COMIN definitions related to compath.py and new GLDAS tag #565
Conversation
- update ROTDIR setting in NCO mode base config to use compath.py in its definition - this change supports the removal of a RUN_ENVIR=nco if-block in the JJOB scripts that set ROTDIR Refs: NOAA-EMC#399
- remove a RUN_ENVIR=nco if-block in JJOB scripts that set ROTDIR via COMROOT - ROTDIR is now set from the configuration level using compath.py - also update COMIN[COMOUT]wave paths in JGLOBAL_FORECAST to use compath.py for defaults Refs: NOAA-EMC#399
- update GLDAS tag to gldas_gfsv16_release.v1.24.0 - update WAFS to gfs_wafs.v6.2.6 Refs: NOAA-EMC#399
- remove "-o" after compath.py in COMIN definitions - add "${envir}" and move closing ")" forward in line Refs: NOAA-EMC#399
- update WAFS tag in sorc/checkout.sh and release notes Refs: NOAA-EMC#399
…NOAA/global-workflow into feature/ops-wcoss2 * 'feature/ops-wcoss2' of https://github.com/KateFriedman-NOAA/global-workflow: revert ecflow include files to NCO versions. Will adapt as necessary for proper use
- update COMIN paths in GEMPAK JJOB scripts for COMINukmet, COMINecmwf, and COMINnam to add the respective systems to the end of the path definition Refs: NOAA-EMC#399
export COMINwave=${COMINwave:-$(compath.py ${envir}/${NET}/${gfs_ver})/${CDUMP}.${PDY}/${cyc}/wave} | ||
export COMOUTwave=${COMOUTwave:-$(compath.py -o ${NET}/${gfs_ver})/${CDUMP}.${PDY}/${cyc}/wave} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this going to affect development?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extensive use of compath.py
in the JJOB is going to cause a lot of NCO
specific blocks. JJOBS are agnostic to the machine or platform. Using tools such as compath.py
in a j-job is not permissible, since it does not exist on any other machine except WCOSS.
IMO, as long as it is only there as a default if the variable is undefined, I think it's appropriate. |
* update submodule for ccpp/physics: Revert calculation of T2m in NOAH-MP
This PR includes changes to address feedback from NCO about how ROTDIR is set in the JJOB scripts, a correction to COMIN definitions, and two tag updates:
COMINwave
andCOMOUTwave
settings inJGLOBAL_FORECAST
to usecompath.py
in the default setting, will use prior setROTDIR
from configuration level otherwiseROTDIR
definition inconfig.base.nco.static
(NCO mode) to usecompath.py
:-o
after compath.py, add${envir}
, and adjust line to compensategldas_gfsv16_release.v1.24.0
gfs_wafs.v6.2.7
Including @WeiWei-NCO for feedback.