Updates to ROTDIR/COMIN definitions related to compath.py and new GLDAS tag #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update ROTDIR setting in NCO mode base config to use compath.py in its definition - this change supports the removal of a RUN_ENVIR=nco if-block in the JJOB scripts that set ROTDIR Refs: NOAA-EMC#399
- remove a RUN_ENVIR=nco if-block in JJOB scripts that set ROTDIR via COMROOT - ROTDIR is now set from the configuration level using compath.py - also update COMIN[COMOUT]wave paths in JGLOBAL_FORECAST to use compath.py for defaults Refs: NOAA-EMC#399
- update GLDAS tag to gldas_gfsv16_release.v1.24.0 - update WAFS to gfs_wafs.v6.2.6 Refs: NOAA-EMC#399
- remove "-o" after compath.py in COMIN definitions
- add "${envir}" and move closing ")" forward in line
Refs: NOAA-EMC#399
- update WAFS tag in sorc/checkout.sh and release notes Refs: NOAA-EMC#399
…NOAA/global-workflow into feature/ops-wcoss2 * 'feature/ops-wcoss2' of https://github.com/KateFriedman-NOAA/global-workflow: revert ecflow include files to NCO versions. Will adapt as necessary for proper use
WeiWei-NCO
reviewed
Jan 12, 2022
WeiWei-NCO
reviewed
Jan 12, 2022
- update COMIN paths in GEMPAK JJOB scripts for COMINukmet, COMINecmwf, and COMINnam to add the respective systems to the end of the path definition Refs: NOAA-EMC#399
aerorahul
reviewed
Jan 12, 2022
Comment on lines
+114
to
+115
| export COMINwave=${COMINwave:-$(compath.py ${envir}/${NET}/${gfs_ver})/${CDUMP}.${PDY}/${cyc}/wave} | ||
| export COMOUTwave=${COMOUTwave:-$(compath.py -o ${NET}/${gfs_ver})/${CDUMP}.${PDY}/${cyc}/wave} |
There was a problem hiding this comment.
how is this going to affect development?
aerorahul
requested changes
Jan 12, 2022
There was a problem hiding this comment.
The extensive use of compath.py in the JJOB is going to cause a lot of NCO specific blocks. JJOBS are agnostic to the machine or platform. Using tools such as compath.py in a j-job is not permissible, since it does not exist on any other machine except WCOSS.
IMO, as long as it is only there as a default if the variable is undefined, I think it's appropriate. |
kayeekayee
pushed a commit
to kayeekayee/global-workflow
that referenced
this pull request
May 30, 2024
* update submodule for ccpp/physics: Revert calculation of T2m in NOAH-MP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to address feedback from NCO about how ROTDIR is set in the JJOB scripts, a correction to COMIN definitions, and two tag updates:
COMINwaveandCOMOUTwavesettings inJGLOBAL_FORECASTto usecompath.pyin the default setting, will use prior setROTDIRfrom configuration level otherwiseROTDIRdefinition inconfig.base.nco.static(NCO mode) to usecompath.py:-oafter compath.py, add${envir}, and adjust line to compensategldas_gfsv16_release.v1.24.0gfs_wafs.v6.2.7Including @WeiWei-NCO for feedback.