Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add tag to pslots with generate_workflows #3036

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Oct 25, 2024

Description

generate_workflows.sh would only use the case name as the pslot, leading to conflicts if you try to run two different sets at the same time. Now there is a new option that allows a 'tag' to the case name when determining the pslots:

generate_workflows.sh -t <tag>

tag: string to be added to end of case name

For example, this:

generate_workflows.sh -t test

Will result in pslots of C48_ATM_test, C48_S2SW_test, etc.

This is similar to how the CI system appends the hash to the pslots, but allows flexibility since this is a command-line tool.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Ran generate_workflows.sh both with and without the new -t option.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@WalterKolczynski-NOAA WalterKolczynski-NOAA force-pushed the feature/generate_workflows_tag branch 2 times, most recently from 909349c to 0a32933 Compare October 25, 2024 04:26
`generate_workflows` would only use the case name as the pslot,
leading to conflicts if you try to run two different sets at the
same time. Now there is a new option that allows a 'tag' to the
case name when determining the pslots:

```
generate_workflows -t <tag>

tag: string to be added to end of case name
```

For example, this:

```
generate_workflows -t test
```

Will result in pslots of `C48_ATM_test`, `C48_S2SW_test`, etc.
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this feature Walter!

@DavidHuber-NOAA DavidHuber-NOAA merged commit 39d0b8b into NOAA-EMC:develop Oct 25, 2024
5 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/generate_workflows_tag branch October 25, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants