-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support global-workflow using Rocky 8 on CSPs #2998
base: develop
Are you sure you want to change the base?
Conversation
@@ -50,6 +50,10 @@ | |||
export wavempexec=${launcher} | |||
export wave_mpmd=${mpmd_opt} | |||
|
|||
elif [[ "${step}" = "prep_emissions" ]]; then | |||
|
|||
export APRUN = ${APRUN_default} |
Check failure
Code scanning / shellcheck
Remove spaces around = to assign. Error
@@ -50,6 +50,10 @@ | |||
export wavempexec=${launcher} | |||
export wave_mpmd=${mpmd_opt} | |||
|
|||
elif [[ "${step}" = "prep_emissions" ]]; then | |||
|
|||
export APRUN = ${APRUN_default} |
Check warning
Code scanning / shellcheck
This does not export 'APRUN_default'. Remove $/${} for that, or use ${var?} to quiet. Warning
@@ -50,6 +50,10 @@ | |||
export wavempexec=${launcher} | |||
export wave_mpmd=${mpmd_opt} | |||
|
|||
elif [[ "${step}" = "prep_emissions" ]]; then | |||
|
|||
export APRUN = ${APRUN_default} |
Check notice
Code scanning / shellcheck
Double quote to prevent globbing and word splitting. Note
@@ -45,7 +45,7 @@ | |||
|
|||
elif [[ "${step}" = "prep_emissions" ]]; then | |||
|
|||
export APRUN | |||
export APRUN = ${APRUN_default} |
Check failure
Code scanning / shellcheck
Remove spaces around = to assign. Error
@@ -45,7 +45,7 @@ | |||
|
|||
elif [[ "${step}" = "prep_emissions" ]]; then | |||
|
|||
export APRUN | |||
export APRUN = ${APRUN_default} |
Check warning
Code scanning / shellcheck
This does not export 'APRUN_default'. Remove $/${} for that, or use ${var?} to quiet. Warning
@@ -45,7 +45,7 @@ | |||
|
|||
elif [[ "${step}" = "prep_emissions" ]]; then | |||
|
|||
export APRUN | |||
export APRUN = ${APRUN_default} |
Check notice
Code scanning / shellcheck
Double quote to prevent globbing and word splitting. Note
Description
With ParallelWorks now default Rocky 8 on CSPs, and move to Rocky 8 only after 1/1/2025,
we need to modify global-workflow module files to use Rocky 8 supported spack-stack,
and test compile and run to make sure all works under Rocky 8.
Resolves #2997
Type of change
Change characteristics
Does this change require a documentation update? YES/NO
How has this been tested?
Checklist