-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959
base: develop
Are you sure you want to change the base?
Update global jdas enkf diag job with COMIN/COMOUT for COM prefix #2959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look ok for the most part but some COMOUT
s needs to be changed to COMIN
s.
@KateFriedman-NOAA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested updates alongside other updates look good, thanks @mingshichen-noaa !
|
Automated global-workflow Testing Results:
|
Experiment C96C48_hybatmDA_c55c8630 FAIL on Wcoss2 at 09/27/24 06:42:30 AM Error logs:
Follow link here to view the contents of the above file(s): (link) |
JGDAS_ATMOS_ANALYSIS_DIAG also uses the exglobal_diag.sh script, so they have to be updated at the same time.
|
@WalterKolczynski-NOAA: The jobs (JGDAS_ENKF_*) include JGDAS_ENKF_DIAG, JGDAS_ENKF_ECEN , JGDAS_ENKF_POST, JGDAS_ENKF_SELECT_OBS, JGDAS_ENKF_SFC , JGDAS_ENKF_SNOW_RECENTER, JGDAS_ENKF_UPDATE |
No, you only need to do the ones that are calling the script you modify here (
|
@WalterKolczynski-NOAA and @mingshichen-noaa I see I am tagged in the two messages above, I am wondering if it was intended for Rahul? |
ce6ef56
@RaghuReddy-NOAA |
@mingshichen-noaa Is this PR ready to be reviewed/tested again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, but CI will need to wait until #2928 is merged and then develop merged into this PR, as that PR contains fixes needed for one of the CI tests.
@mingshichen-noaa Before we run this through automated CI, did this pass a test using the C96_atm3DVar case? |
@WalterKolczynski-NOAA
|
Do you have an entry for |
Description
NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jdas enkf diagnostics job.
Refs #2451
Type of change
Change characteristics
How has this been tested?
Checklist