Update snow obs preprocessing job #2946

jiaruidong2017 · 2024-09-20T15:12:00Z

Description

This PR modifies the workflow XML configuration so that the prep snow obs job only runs on the 00z cycle.

This PR also renames the snow_obs and snowobs to the snowcover for highlighting the input IMS data source as snow cover.

Resolves (#2902)

Type of change

Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO
Does this change require an update to any of the following submodules? NO

How has this been tested?

Forecast-only on Hera

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

Replace it with a direct read from BUFR at runtime.

WalterKolczynski-NOAA · 2024-09-27T04:48:25Z

workflow/rocoto/gfs_cycled_xml.py

+        if self._app_config.do_jedisnowda:
+            sdate_snocvr = self._base['SDATE']
+            edate_snocvr = self._base['EDATE']
+            interval_snocvr = to_timedelta(f"24:00:00H")


Suggested change

interval_snocvr = to_timedelta(f"24:00:00H")

interval_snocvr = to_timedelta('24H')

Made changes. Thanks.

WalterKolczynski-NOAA · 2024-09-27T04:51:18Z

workflow/rocoto/gfs_tasks.py

        task_dict = {'task_name': task_name,
                     'resources': resources,
                     'dependency': dependencies,
                     'envars': self.envars,
-                     'cycledef': self.run.replace('enkf', ''),
-                     'command': f'{self.HOMEgfs}/jobs/rocoto/prepsnowobs.sh',
+                     'cycledef': cycledef,


Suggested change

'cycledef': cycledef,

'cycledef': 'gdas_prep_snocvr',

Made changes as suggested. Thanks.

WalterKolczynski-NOAA · 2024-09-27T04:51:24Z

workflow/rocoto/gfs_tasks.py


        deps = []
        dep_dict = {'type': 'task', 'name': f'{self.run}prep'}
        deps.append(rocoto.add_dependency(dep_dict))
        dependencies = rocoto.create_dependency(dep=deps)

-        resources = self.get_resource('prepsnowobs')
-        task_name = f'{self.run}prepsnowobs'
+        cycledef = 'gdas_prep_snocvr'


Suggested change

cycledef = 'gdas_prep_snocvr'

WalterKolczynski-NOAA · 2024-09-27T05:00:50Z

workflow/rocoto/gfs_tasks.py

@@ -591,7 +592,10 @@ def prepsnowobs(self):
    def snowanl(self):

        deps = []
-        dep_dict = {'type': 'task', 'name': f'{self.run}prepsnowobs'}
+        if f'@H' == '00':


@H is a rocoto thing, so this doesn't have any meaning to python when this function is run and this won't work as-is. #2928 is adding support for the undocumented rocoto dependency <taskvalid>. Once that is in, we can use it to make a dependency that works here:

<or> <and> <not><taskvalid task="{self.run}prepsnowcover"/></not> <taskdep task="{self.run}prep"/> </and> <taskdep task="{self.run}prepsnowcover"/> </or>

Thanks @WalterKolczynski-NOAA for the information. Your introduced <taskvalid> above is exactly what we want here. For now, I made some changes here for a place holder.

<or> <taskdep task="gdasprep"/> <taskdep task="gdasprepsnowcover"/> </or>

@WalterKolczynski-NOAA Do you want me to wait for your PR #2928 or proceed to review this PR? I can update to use <taskvalid> after your PR is merged. Please let me know. Thanks.

CoryMartin-NOAA · 2024-10-15T14:17:18Z

@jiaruidong2017 can you resolve conflicts and then, if all his comments are addressed, re-request review from @WalterKolczynski-NOAA ?

…2017/global-workflow into feature/ims_snowcover

jiaruidong2017 · 2024-10-23T11:58:24Z

@WalterKolczynski-NOAA The <taskvalid> is used to update the task dependency as below.

I conducted the test run, and the run was successful. Would you please review this PR? Thanks.

emcbot · 2024-10-24T17:07:39Z

CI Failed on Hera in Build# 3
Built and ran in directory /scratch1/NCEPDEV/global/CI/2946


Experiment C48mx500_3DVarAOWCDA_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:01:00 UTC 2024
Experiment C48mx500_3DVarAOWCDA_ed78b8c4 Terminated: **
Experiment C96_atm3DVar_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:01:11 UTC 2024
Experiment C96_atm3DVar_ed78b8c4 Terminated: **
Experiment C96C48_hybatmDA_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:01:13 UTC 2024
Experiment C96C48_hybatmDA_ed78b8c4 Terminated: **
Experiment C96C48_ufs_hybatmDA_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:01:13 UTC 2024
Experiment C96C48_ufs_hybatmDA_ed78b8c4 Terminated: **
Experiment C48_S2SW_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:01:13 UTC 2024
Experiment C48_S2SW_ed78b8c4 Terminated: **
Experiment C48_S2SWA_gefs_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:01:32 UTC 2024
Experiment C48_S2SWA_gefs_ed78b8c4 Terminated: **
Experiment C48_ATM_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:06:42 UTC 2024
Experiment C48_ATM_ed78b8c4 Terminated: **
Experiment C96_S2SWA_gefs_replay_ics_ed78b8c4 Terminated with  tasks failed and  dead at Thu Oct 24 17:06:42 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_ed78b8c4 Terminated: **

emcbot · 2024-10-24T21:22:43Z

Experiment C48_ATM FAILED on Hera in Build# 4 in
/scratch1/NCEPDEV/global/CI/2946/RUNTESTS/EXPDIR/C48_ATM_ed78b8c4

emcbot · 2024-10-25T08:56:34Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 4 with error logs:

/scratch1/NCEPDEV/global/CI/2946/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_ed78b8c4/logs/2021122100/gdas_snowanl.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-10-25T08:56:42Z

Experiment C96C48_hybatmaerosnowDA FAILED on Hera in Build# 4 in
/scratch1/NCEPDEV/global/CI/2946/RUNTESTS/EXPDIR/C96C48_hybatmaerosnowDA_ed78b8c4

emcbot · 2024-10-25T11:11:27Z

CI Failed on Hera in Build# 4
Built and ran in directory /scratch1/NCEPDEV/global/CI/2946


**CI Failed** on Hera in Build# 3<br>Built and ran in directory `/scratch1/NCEPDEV/global/CI/2946`

Experiment C48mx500_3DVarAOWCDA_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:01:00 UTC 2024
Experiment C48mx500_3DVarAOWCDA_ed78b8c4 Terminated: **
Experiment C96_atm3DVar_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:01:11 UTC 2024
Experiment C96_atm3DVar_ed78b8c4 Terminated: **
Experiment C96C48_hybatmDA_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:01:13 UTC 2024
Experiment C96C48_hybatmDA_ed78b8c4 Terminated: **
Experiment C96C48_ufs_hybatmDA_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:01:13 UTC 2024
Experiment C96C48_ufs_hybatmDA_ed78b8c4 Terminated: **
Experiment C48_S2SW_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:01:13 UTC 2024
Experiment C48_S2SW_ed78b8c4 Terminated: **
Experiment C48_S2SWA_gefs_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:01:32 UTC 2024
Experiment C48_S2SWA_gefs_ed78b8c4 Terminated: **
Experiment C48_ATM_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:06:42 UTC 2024
Experiment C48_ATM_ed78b8c4 Terminated: **
Experiment C96_S2SWA_gefs_replay_ics_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 17:06:42 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_ed78b8c4 Terminated: **
Experiment C48_ATM_ed78b8c4 Terminated with tasks failed and dead at Thu Oct 24 19:12:43 UTC 2024
Experiment C48_ATM_ed78b8c4 Terminated: **
Experiment C48mx500_3DVarAOWCDA_ed78b8c4 Completed 2 Cycles: SUCCESS at Fri Oct 25 01:06:01 UTC 2024
Experiment C96_S2SWA_gefs_replay_ics_ed78b8c4 Completed 1 Cycles: SUCCESS at Fri Oct 25 06:56:27 UTC 2024
Experiment C48_S2SW_ed78b8c4 Completed 2 Cycles: SUCCESS at Fri Oct 25 08:43:42 UTC 2024
Experiment C96C48_hybatmaerosnowDA_ed78b8c4 Terminated with 0
FAIL
FAIL tasks failed and 1 dead at Fri Oct 25 08:56:18 UTC 2024
Experiment C96C48_hybatmaerosnowDA_ed78b8c4 Terminated: FAIL
Error logs:
/scratch1/NCEPDEV/global/CI/2946/RUNTESTS/COMROOT/C96C48_hybatmaerosnowDA_ed78b8c4/logs/2021122100/gdas_snowanl.log
Experiment C48_S2SWA_gefs_ed78b8c4 Completed 1 Cycles: SUCCESS at Fri Oct 25 09:18:51 UTC 2024
Experiment C96C48_hybatmDA_ed78b8c4 Completed 3 Cycles: SUCCESS at Fri Oct 25 10:16:27 UTC 2024
Experiment C96C48_ufs_hybatmDA_ed78b8c4 Completed 3 Cycles: SUCCESS at Fri Oct 25 11:10:55 UTC 2024
Experiment C96_atm3DVar_ed78b8c4 Completed 3 Cycles: SUCCESS at Fri Oct 25 11:11:15 UTC 2024

DavidHuber-NOAA · 2024-10-25T12:53:34Z

It seems the gdas_prepsnowcover job did not materialize when generating the XML for the C96C48_hybatmaerosnowDA case. It's not clear to me why it didn't.

jiaruidong2017 · 2024-10-25T14:20:27Z

It seems the gdas_prepsnowcover job did not materialize when generating the XML for the C96C48_hybatmaerosnowDA case. It's not clear to me why it didn't.

@DavidHuber-NOAA Thanks for checking this. I don't why the gdas_prepsnowcover job didn't start in your CI test. When I checked the XML, the gdas_prepsnowcover job was available in your XML.

I have generated the gdas_prepsnowcover job locally and conducted the test run successfully. I will take further look on this.

DavidHuber-NOAA · 2024-10-25T14:27:57Z

@jiaruidong2017 My apologies, you are correct. It did get written to the XML, but rocotostat does not show the task. I wonder if there is an issue with the dependencies.

DavidHuber-NOAA · 2024-10-25T14:29:19Z

Ah, I see the issue. The cycledefs for the task is incorrect. It reads

<task name="gdas_prepsnowcover" cycledefs="gdas_prep_snocvr" maxtries="&MAXTRIES;">

but should be

<task name="gdas_prepsnowcover" cycledefs="gdas" maxtries="&MAXTRIES;">

workflow/rocoto/gfs_tasks.py

workflow/rocoto/gfs_cycled_xml.py

jiaruidong2017 and others added 12 commits September 9, 2024 10:58

Remove the GTS BUFR2IODA part of the snow obs prep job and

4098f10

Replace it with a direct read from BUFR at runtime.

Change HOMEgfs to PARMgfs.

8d1bc87

Merge branch 'develop' into feature/snow_gtsobs

6ff65bc

Merge branch 'develop' into feature/snow_gtsobs

2295cab

Made changes to stage the static GTS mapping files.

5074d11

Change the name to be more descriptive.

f122edf

Merge branch 'develop' into feature/snow_gtsobs

73b4ec0

Update IMS preprocessing job.

086158d

Rename IMS snow preprocessing jobs/names to be snowcover

2df23be

Merge branch 'develop' into feature/ims_snowcover

bb8775a

Merge branch 'develop' into feature/ims_snowcover

5ddf552

Merge branch 'develop' into feature/ims_snowcover

0bfbff7

WalterKolczynski-NOAA requested changes Sep 27, 2024

View reviewed changes

Address reviewer's comments.

3c08705

WalterKolczynski-NOAA added the blocked Issue is currently being blocked by another issue label Oct 1, 2024

Merge branch 'develop' into feature/ims_snowcover

850f672

jiaruidong2017 added 4 commits October 15, 2024 12:04

Merge branch 'develop' into feature/ims_snowcover

6f2fc66

Merge branch 'feature/ims_snowcover' of https://github.com/jiaruidong…

30c19d4

…2017/global-workflow into feature/ims_snowcover

Merge branch 'develop' into feature/ims_snowcover

08bb8d8

Merge branch 'develop' into feature/ims_snowcover

8a4a743

jiaruidong2017 requested review from KateFriedman-NOAA, DavidHuber-NOAA and aerorahul as code owners October 22, 2024 23:32

jiaruidong2017 added 3 commits October 22, 2024 20:48

Update to use <taskvalid> for managing the rocoto dependency.

b12a375

Fix the pynorms error.

679e57e

Fix an error.

d97480a

jiaruidong2017 requested a review from WalterKolczynski-NOAA October 23, 2024 11:58

WalterKolczynski-NOAA removed the blocked Issue is currently being blocked by another issue label Oct 23, 2024

emcbot added the CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed label Oct 24, 2024

WalterKolczynski-NOAA removed the CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed label Oct 25, 2024

emcbot added the CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed label Oct 25, 2024

emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed labels Oct 25, 2024

DavidHuber-NOAA reviewed Oct 25, 2024

View reviewed changes

workflow/rocoto/gfs_tasks.py Show resolved Hide resolved

DavidHuber-NOAA reviewed Oct 25, 2024

View reviewed changes

workflow/rocoto/gfs_cycled_xml.py Outdated Show resolved Hide resolved

DavidHuber-NOAA reviewed Oct 25, 2024

View reviewed changes

workflow/rocoto/gfs_cycled_xml.py Show resolved Hide resolved

Update to run gdas_prepsnowcover job on every 00Z cycle.

eac7e1f

jiaruidong2017 dismissed KateFriedman-NOAA’s stale review via eac7e1f October 25, 2024 17:17

DavidHuber-NOAA reviewed Oct 25, 2024

View reviewed changes

workflow/rocoto/gfs_cycled_xml.py Outdated Show resolved Hide resolved

jiaruidong2017 added 2 commits October 25, 2024 14:33

Made changes as reviewer suggested.

96254c4

Fix pynorm error.

a00f9e8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update snow obs preprocessing job #2946

Update snow obs preprocessing job #2946

jiaruidong2017 commented Sep 20, 2024

WalterKolczynski-NOAA Sep 27, 2024

jiaruidong2017 Sep 27, 2024

WalterKolczynski-NOAA Sep 27, 2024

jiaruidong2017 Sep 27, 2024

WalterKolczynski-NOAA Sep 27, 2024

WalterKolczynski-NOAA Sep 27, 2024

jiaruidong2017 Sep 27, 2024

jiaruidong2017 Oct 15, 2024

CoryMartin-NOAA commented Oct 15, 2024

jiaruidong2017 commented Oct 23, 2024

emcbot commented Oct 24, 2024

emcbot commented Oct 24, 2024

emcbot commented Oct 25, 2024

emcbot commented Oct 25, 2024

emcbot commented Oct 25, 2024

DavidHuber-NOAA commented Oct 25, 2024

jiaruidong2017 commented Oct 25, 2024

DavidHuber-NOAA commented Oct 25, 2024

DavidHuber-NOAA commented Oct 25, 2024

	interval_snocvr = to_timedelta(f"24:00:00H")
	interval_snocvr = to_timedelta('24H')

Update snow obs preprocessing job #2946

Are you sure you want to change the base?

Update snow obs preprocessing job #2946

Conversation

jiaruidong2017 commented Sep 20, 2024

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CoryMartin-NOAA commented Oct 15, 2024

jiaruidong2017 commented Oct 23, 2024

emcbot commented Oct 24, 2024

emcbot commented Oct 24, 2024

emcbot commented Oct 25, 2024

emcbot commented Oct 25, 2024

emcbot commented Oct 25, 2024

DavidHuber-NOAA commented Oct 25, 2024

jiaruidong2017 commented Oct 25, 2024

DavidHuber-NOAA commented Oct 25, 2024

DavidHuber-NOAA commented Oct 25, 2024