Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract common j-job tasks #1229

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Jan 6, 2023

Description
Takes all of the tasks that are common to all j-jobs and abstracts them out into a shared script that is sourced by each job:

  • Set and create $DATA directory
  • Call setpy and set $cycle
  • Set pid, pgmout, and pgmerr
  • Source config files
  • Source machine environment file

The common j-job header script is called by passing a list of config files to source:

${HOMEgfs}/ush/jjob_header.sh [config1 [config2 [...]]]

Some pre j-job rocoto entry scripts (jobs/rocoto/*) are currently doing much more than they should be. These sometimes required extra finagling, usually pre-calling the jjob header in the rocoto script before it does something.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Cycled test on Orion
  • Cycled test on Hera
  • Cycled test on WCOSS2
  • Coupled test on Orion
  • Coupled test on Hera
  • Couple test on WCOSS2

Post sounding (bufr) and gempak jobs complete successfully
AWIPS and WAFS failing for unrelated reasons
GDAS App jobs not tested
Some j-jobs are not called in the development workflow. TODOs an corresponding issues have been added to these.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Dependencies
#1212
#1214
#1216
#1218

Takes all of the tasks that are common to all j-jobs and abstracts
them out into a shared script that is sourced by each job:
- Set and create $DATA
- Call setpy and set $cycle
- Set pid, pgmout, and pgmerr
- Source config files
- Source machine environment file

The common j-job header script is called by passing a list of config
files to source:
```
${HOMEgfs}/ush/jjob_header.sh [config1 [config2 [...]]]
```

Some pre j-job rocoto entry scripts (`jobs/rocoto/*`) are currently
doing much more than they should be. These sometimes required extra
finagling, usually pre-calling the jjob header in the rocoto script
before it does something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant