Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize variable filecount in forecast_det.sh #1190

Closed
wants to merge 1 commit into from

Conversation

lgannoaa
Copy link
Contributor

@lgannoaa lgannoaa commented Dec 16, 2022

Provide a fix to initialize variable filecount in forecast_det.sh.
Fix issue #1140

Description
The filecount in script forecast_det.sh need to be initialized.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Cycled test on WCOSS
  • Forecast-only test on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@lgannoaa lgannoaa self-assigned this Dec 16, 2022
WalterKolczynski-NOAA pushed a commit that referenced this pull request Dec 18, 2022
Undoes the portion of PR #1179 that caused a new bug while attempting to fix #1140, without removing the linter fixes. Instead `/dev/null` is 'searched' if `${RSTDIR_ATM}` is not defined. That situation will always result in zero files found, ensuring a rerun is not triggered.

Fixes #1140 
Fixes #1185
Moots #1190
@WalterKolczynski-NOAA
Copy link
Contributor

Closing as moot as #1186 corrected this issue in a more robust manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants