-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fix reorg and remove gfs-utils code #1009
Implement fix reorg and remove gfs-utils code #1009
Commits on Oct 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c0634fa - Browse repository at this point
Copy the full SHA c0634faView commit details -
Update link_workflow.sh for fix set reorg
- Source new fix.ver file to get fix subfolder version values for setting up fix folder symlinks. - Change "fix_NEW" to "fix" for FIX_DIR paths: use newly reorganized and versioning fix set. - Remove "fix_" from /fix folder symlink names. - Update /fix folder symlink creation to use version variables from fix.ver. - Update GSI and GDAS fix symlinks. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 104ca75 - Browse repository at this point
Copy the full SHA 104ca75View commit details -
Update JEDI fix subfolder path name in configs
- Change FV3JEDI_FIX in related configs to change the path subfolder from "fix_jedi" to "gdas". Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for eafd6b3 - Browse repository at this point
Copy the full SHA eafd6b3View commit details -
Update fix subfolders in configs to remove "fix_"
- Remove "fix_" text from fix file paths in several configs. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 4e472f8 - Browse repository at this point
Copy the full SHA 4e472f8View commit details -
Remove "fix_" from fix subfolder paths in scripts
- Update /scripts and /ush scripts to remove the "fix_" text from fix subfolder paths. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for f918698 - Browse repository at this point
Copy the full SHA f918698View commit details -
Create versions folder and fix.ver
- Create a new version folder to hold version files. - Create a new fix.ver to hold fix file versions. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 209d62b - Browse repository at this point
Copy the full SHA 209d62bView commit details -
Remove gfs-utils code and update for new fix
Removes all of the code and scripts that were moved to the new gfs-utils repo and adjusts workflow scripts to build and use them from the new location. Some of the build scripts had unnecessary calls to machine-setup that are removed because the lower-level script already has the same functionality. This PR also includes updates to use the new fix organization. This includes the addition of a fix versions file, updates to the link script, and some changes in the fix directories used by scripts to account for files that have been relocated. The versions file sets the version number for each component of fix, so that fix can be more easily maintained and documented. The initial versions are all the same, and correspond to the old fix_NEW directory (other than some directories have been renamed or reorganizated). Finally, the link script has been updated to match the syntax of the rest of the build system (`checkout.sh` and `build_all.sh`). `link_workflow.sh` now detects the machine automatically instead of requiring an argument, and dev mode, which used to be set using `emc` as an argument, is now assumed. To run in ops mode (copy instead of link), the `-o` option is used. The full syntax is now simply: ``` ./link_workflow.sh [-o] -o: Run in operations (NCO) mode (copy instead of link) ``` This commit uses a temporary clone of the UFS_UTILS repo pending the merger of ufs-community/UFS_UTILS#688. Fixes NOAA-EMC#356
Configuration menu - View commit details
-
Copy full SHA for 18a599a - Browse repository at this point
Copy the full SHA 18a599aView commit details -
Correct merge error in link script
An incorrect resolution of a merge conflict resulted in an undefined variable in the link script. Refs: NOAA-EMC#356
Configuration menu - View commit details
-
Copy full SHA for 1b7c418 - Browse repository at this point
Copy the full SHA 1b7c418View commit details -
Update gfs utils to pick up Orion gempak fix
Updates the gfs utils version to pick up a fix for an incorrect gempak module version on Orion.
Configuration menu - View commit details
-
Copy full SHA for f411e0a - Browse repository at this point
Copy the full SHA f411e0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 053947e - Browse repository at this point
Copy the full SHA 053947eView commit details -
Revert change to checkout for GSI-adjacent repos
An earlier change had inadvertently stopped checking out GSI Monitor, GSI Utils, and GLDAS when GDAS is used instead of GSI. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for acadfdb - Browse repository at this point
Copy the full SHA acadfdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7e1f29 - Browse repository at this point
Copy the full SHA d7e1f29View commit details -
First wave of linter fixes for removing gfs-utils code/fix reorg. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 797dd70 - Browse repository at this point
Copy the full SHA 797dd70View commit details -
Linter fixes for fix dir reorg
Second wave of linter fixes for removing gfs-utils code/fix reorg. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 0babfaa - Browse repository at this point
Copy the full SHA 0babfaaView commit details -
Wave 3 of linter fixes for fix update
Wave 3 of linter fixes for removing gfs-utils code/fix reorg. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 7a60a28 - Browse repository at this point
Copy the full SHA 7a60a28View commit details -
Wave 4 linter fixes for fix update
Wave 4 of linter fixes for removing gfs-utils code/fix reorg. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for fe467bd - Browse repository at this point
Copy the full SHA fe467bdView commit details -
Fix minor syntax error in link script
The last merge from develop introduced a minor syntax error in the link script due to a bad conflict resolution. The issue is now corrected. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for b79ef4f - Browse repository at this point
Copy the full SHA b79ef4fView commit details -
Update new GLDAS scripts for new fix pattern
GLDAS scripts were recent moved into the workflow repo and need to be updated for the new fix structure like other components. Refs: NOAA-EMC#622, NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for 190f97f - Browse repository at this point
Copy the full SHA 190f97fView commit details -
Fix default missing var syntax error
Corrects a `:-?` to `:?`. Refs: NOAA-EMC#356
Configuration menu - View commit details
-
Copy full SHA for c8ce296 - Browse repository at this point
Copy the full SHA c8ce296View commit details -
Move root fixdir setting higher in link script
Moved the setting of FIXDIR higher so it errors on an unknown machine sooner. Also removed redundant version file load. Refs: NOAA-EMC#966
Configuration menu - View commit details
-
Copy full SHA for c80ad79 - Browse repository at this point
Copy the full SHA c80ad79View commit details -
Fix erronous CR in log directory
The closing quotation mark when making the logdir in checkout was erroneously split into a new line.
Configuration menu - View commit details
-
Copy full SHA for 73a0b71 - Browse repository at this point
Copy the full SHA 73a0b71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71b5114 - Browse repository at this point
Copy the full SHA 71b5114View commit details