Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify setup_expt.py and setup_expt_fcstonly.py #536

Closed
aerorahul opened this issue Dec 23, 2021 · 0 comments · Fixed by #537
Closed

Unify setup_expt.py and setup_expt_fcstonly.py #536

aerorahul opened this issue Dec 23, 2021 · 0 comments · Fixed by #537
Assignees

Comments

@aerorahul
Copy link
Contributor

In the present state, there are 2 entry points to the workflow setup.
One for cycled and another for forecast-only modes of operation.

As more "modes" are added, this adds duplication of code fragments and burden to the maintainers.

This issue documents the unification of setup_expt.py and setup_expt_fcstonly.py

WalterKolczynski-NOAA added a commit that referenced this issue Feb 1, 2022
The incorrect path to config.base was displayed to the user after
the experiment directory was created. The correct paths are now
shown.

Refs: #536
WalterKolczynski-NOAA added a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Feb 2, 2022
Changes the links created for cycled ICs from INPUT to RESTART.

Refs: NOAA-EMC#536
aerorahul pushed a commit that referenced this issue Feb 2, 2022
* Only copy cycled ICs if specified

In cycled mode when --icsdir was not specified, setup would create
a bunch of links to the default location, $HOME, inside of $COMROT.
Since most people don't keep initial conditions there, this resulted
in a bunch of dead links. This may also cause problems when people
go to stage their ICs from elsewhere, as they may get written to
$HOME via the links and on most HPC $HOME space is very limited.

Now the default is changed back to None, and links are only created
if a value is specified. Dead links will still be created if the
target does not exist, but at least users will not unwittingly be
creating them.

Refs: #537

* Change cycled IC links INPUT to RESTART

Changes the links created for cycled ICs from INPUT to RESTART.

Refs: #536
WalterKolczynski-NOAA added a commit that referenced this issue Feb 2, 2022
Checks that --icsdir is specified when running a coupled app (S2S
or S2SW) and throws an error if it is not.

Refs: #536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant