Add CROW to develop branch #13
Assignees
Labels
feature
New feature or request
Comments
|
Pull request #20 created. |
KateFriedman-NOAA
added a commit
that referenced
this issue
Mar 12, 2020
… adjustments to link script and gitignore
|
Taking a deep dive into these changes. Checked out feature/crow-merge on Venus, did a sync merge of develop into feature/crow-merge, adjusted .gitignore a bit, adjusted FIX_DIR linking in link_fv3gfs.sh, and added CROW to Externals.cfg config (removed .gitmodules). Committed all that at |
Closed
KateFriedman-NOAA
added a commit
that referenced
this issue
Mar 12, 2020
…ge_externals when it tries to make it
KateFriedman-NOAA
added a commit
that referenced
this issue
Mar 12, 2020
KateFriedman-NOAA
added a commit
that referenced
this issue
Mar 25, 2020
KateFriedman-NOAA
added a commit
that referenced
this issue
Mar 25, 2020
|
Unclear if coupled-crow will come back to develop soon. Closing issue. |
WalterKolczynski-NOAA
added a commit
that referenced
this issue
Oct 8, 2021
The formatting for rocoto_viewer is updated to follow the PEP-8 standard. This mostly involves standardizing spacing, splitting multi-import lines, and eliminating bare except keywords. This is in preparation for updating to python3. Refs: #13
WalterKolczynski-NOAA
added a commit
that referenced
this issue
Oct 8, 2021
The rocoto_viewer script is updated to python3. In addition to making the necessary syntax updates like converting print statements into print functions (adding parentheses), this requried removing the dependency on produtils scripts (which are still in python2). This change will also make the script more portable. The largest chunk of changes to remove produtils revolves around making system calls to run rocoto. These are replaced with a simple wrapper function that calls subprocess, captures the output, and returns it as a string. This also allows for the streamlining of these portions of code. A fallback is added in case lxml is not available. This will only cause problems if lxml is not available and the user tries to read a workflow that uses external entities, in which case a message will be displayed notifying the user of the issue and providing instructions on how to install lxml with pip. A similar existing message for dateutil (used for UGCS's monthly increment) was updated similarly. Some incidental syntax updating and unused variable removal was done as they were encountered, but a more complete cleaning of these is still needed. Refs: #13, #14
WalterKolczynski-NOAA
added a commit
that referenced
this issue
Oct 8, 2021
All strings still using the modulo (%) operator for substitution are replaced with more readable f-strings instead. Some remaining instances that were using functions from produtil that were missed in the previous commit are updated to replace those functions. Two functions for validating a POSIX shell string are copied and updated from produtil for use here. Some minor bugs and typos are resolved. Replaced the former cPickle (which is not available for python3) calls with pickle calls. Fixed bugs in rocotocheck related to passing an int argument instead of a string to syscall and not defining current_check_time. Corrected issue with rocoto_viewer not immediately exiting when the workflow cannot be parsed (usually because lxml could not be loaded). Refs: #13, #14
WalterKolczynski-NOAA
added a commit
that referenced
this issue
Oct 8, 2021
Documentation blocks are added for all of the new functions added to rocotoviewer. A more complete documentation of pre-existing functions is still needed. Refs: #13
lgannoaa
pushed a commit
to lgannoaa/global-workflow
that referenced
this issue
Feb 9, 2022
NOAA-EMC#13) * Change module name machine and physcons to machine_post and physcons_post for solving conflict with FV3 model setting. * Tweak physcons.f
lgannoaa
pushed a commit
to lgannoaa/global-workflow
that referenced
this issue
Feb 9, 2022
* Turn on GSD cloud ceiling calculation for RRFS dev. * Updates to UPP for RRFS applications (NOAA-EMC#3) * Updates to UPP for RRFS applications: 1) Adding a RRFS-specific .xml control file and a corresponding .txt flat file. Note that script changes (pending) are needed to leverage the new flat file. However, this code will work in current real-time configurations. 2) Adding GSL experimental ceiling diagnostics, GSL visibility diagnostic, and GSL sea-level pressure reduction (MAPS). Also adding TKE and aerosol number concentrations. 3) Code clean-up for ceiling-related diagnostics; added comments, etc. 4) Removing several non-needed variables, originally inherited from FV3-SAR community configuration. * Updating UPP control files to specify GRIB2 generating center as "noaa_fsl_boulder" and the generating process as "hrrr". The "hrrr" specification is temporary, and will eventually be switched to "rrfs" once required changes to the "NCEPLIBS-g2tmpl" library are available. (NOAA-EMC#4) * Fix some out-of-bounds reads that caused the RRFS UPP to crash. (NOAA-EMC#5) * Adding README file (NOAA-EMC#7) * Adding README file to describe process of making a "flat" file. * Updates to README to improve explanation of input/output files. * Code to read in Flash Flood Guidance (FFG) and Average Recurrence Interval (ARI) precipitation datasets for comparison with model QPF within UPP. * Fixed a syntax error in SURFCE.f * Getting rid of GRIB1 output option to be consistent with rest of code. * Changing field numbers to avoid conflict with existing RRFS-dev1 fields. * Putting exceedance grids in flat files for testing in RRFS UPP. * Corrected the 1h and run total precip names for calculating exceedances in SURFCE.f * Bug fix in SURFCE.f if statements. * Removing changes to RQSTFLD.F since GRIB1 is no longer used in UPP. * Merging NOAA-GSL development on top of NOAA-EMC UPP for testing. * Correcting minor typos in SURFCE.f to allow testing. * Update code based on testing with RRFS cases. * Update part of the code based on current EMC develop branch for comparing the test results with the merged version.(NOAA-EMC#9) * Fixed several bugs in the code. * Modifications to SURFCE.f to check for existence of FFG files. * Bug fixes for FFG file existence check, and changes to handle rotated lat-lon grid interpolation for FFG * Bug fixes for FFG existence checks in SURFCE.f * Another bug fix for SURFCE.f * Updating XML and flat txt files to include a 65th vertical level to be consistent with updated FV3LAM model with higher model top. (NOAA-EMC#13) * Code cleanup for QPF - FFG comparison. Comparison put into subroutine. * Cleanup of SURFCE.f; moving the FFG comparisons into a subroutine. * Final cleanup of exceedance code for QPF vs FFG. * Removing some commented out variable declarations. * Additional cleanup recommended by Ming: we really only need two exceedance variables; one for 1h FFG and one for run total FFG exceedances. * Further cleanup of FFG code, simplifying to two fields (1h acc and run total acc) * Adding ARI comparison fields for 2y, 5y, 10y, and 100y ARIs. * Changes to output 9 soil levels from FV3LAM if we are running 9 level RUC LSM. * Adding flat txt file for UPP. * Commenting out the use of the ARI exceedances for now. We can switch them on later. * Bug fix in INITPOST_NETCDF.f : need to use both ncid2d and ncid3d in this subroutine! * Adding NOAA-GSL code changes on top of latest NOAA-EMC UPP. * Couple of bug fixes in NOAA-EMC code. Bugs were leading to PRMSL and -10C REFD being all zeroes. * Cleaning up code to get rid of unnecessary differences from EMC. * Putting all new GSL variables into EMC's unified post_avblflds.xml. Note that EMC's unified post_avblflds.xml does not validate using the avblflds Schema. * Updating postconfig-NT.txt file for GSL RRFS based on merged post_avblflds.xml file. * Adding RRFS control files to makefile. * Changing back scale for WEASD_ON_SURFACE to previous default, thanks to suggestion from Wen Meng. * Reverting name of cldfra based on feedback from Eric Aligo. * Reverting changes in fv3lam_post_avblflds.xml since GSL new variables are now included in post_avblflds.xml * Changing experimental ceiling level type from "ceiling" to "cloud_ceilng" * Updating 3drtma_postcntrl.xml with revised name for GSD_EXP_CEILING. This also affects postxconfig-NT-3drtma.txt. postxconfig-NT-fv3lam_rrfs.txt also changed due to changes in post_avblflds.xml * Introducing if statement for call of NGMSLP, to avoid calling unless it is needed. Co-authored-by: Ming.Hu <Ming.Hu@noaa.gov> Co-authored-by: Christina Holt <56881914+christinaholtNOAA@users.noreply.github.com> Co-authored-by: Christina Holt <Christina.Holt@noaa.gov> Co-authored-by: Jaymes Kenyon <jaymes.kenyon@noaa.gov> Co-authored-by: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
zhanglikate
pushed a commit
to zhanglikate/global-workflow
that referenced
this issue
Oct 6, 2022
fv3atm github issue NOAA-EMC#13: change ifmin to zero at fh00 for inline post
zhanglikate
pushed a commit
to zhanglikate/global-workflow
that referenced
this issue
Oct 6, 2022
…latest_code Update to MYNN Surface Layer Scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: