Coupled stochy fixes for precipitation #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge in updates from emc version
update from EMC fork
update to NOAA-EMC fork
|
I approved the corresponding ccpp-physics change. Merging will have to be coordinated with the ufs-weather-model commit queue. |
|
Update 03/24/2020: this PR has been pulled into #86 and will be merged automatically as part of it. No need to close this PR, it will be flagged as merged automatically. |
|
This PR was merged as part of #86 - for some reason, it doesn't show up as "merged" automatically. Please double-check, but I think this PR can be closed. |
|
Hi Dom,
I see the updates are now in develop, the PR can be closed
Thanks,
Phil
…On Fri, Mar 27, 2020 at 1:19 PM Dom Heinzeller ***@***.***> wrote:
This PR was merged as part of #86
<#86> - for some reason, it
doesn't show up as "merged" automatically. Please double-check, but I think
this PR can be closed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#85 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJIRVJFLYMIHCA53ESU6AIDRJT3WJANCNFSM4LR7YJZQ>
.
--
Philip Pegion
NOAA/ESRL/PSD-CIRES
(303) 497-7897
philip.pegion@noaa.gov
|
Thanks! Importantly, the commits still show you as author, so you get the credit for doing the work (and not me for pulling them in). |
|
PR #86 was committed, close this PR. |
climbfuji
pushed a commit
to climbfuji/fv3atm
that referenced
this pull request
Apr 26, 2021
…_repo_fix_pr Fix following PR 84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request references ufs-community/ufs-s2s-model#58, there was an inconsistency between the partition of the rain and snow and the rain/snow tendency that was later perturbed as part of SPPT.
The update to GFS_physics_driver.F90 makes these consistent.