Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket change during integration #835

Merged
merged 19 commits into from
May 28, 2024
Merged

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Description

RRFS requested to allow bucket change during integration. This is initial code updates for that capability.

At this time, the bucket (fhzero) is updated the forecast side, we need to update attribute at forecast time to pass the change to write grid component.

NOTE This PR replaces #775

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? Regression test
What compilers / HPCs was it tested with? Intel/GNU Hera
Are the changes covered by regression tests? Yes
Have the ufs-weather-model regression test been run? Yes. On what platform? Hera

  • Will the code updates change regression test baseline? Yes.
  • If yes, why? The type if fhzero global attribute if physics history outputs is changed from INT to FLOAT
$ nccmp -dfg phyf006.nc /scratch2/NAGAPE/epic/UFS-WM_RT/NEMSfv3gfs/develop-20240503/regional_control_intel/phyf006.nc
DIFFER : GLOBAL ATTRIBUTE TYPES : fhzero : FLOAT <> INT

Dependencies

N/A

@jkbk2004 jkbk2004 merged commit b364000 into NOAA-EMC:develop May 28, 2024
6 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the fhbucket branch May 29, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to handle accumulations and max/min computations over multiple time windows
4 participants