Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] Update module_write_netcdf to avoid hangs in RRFS runs #810

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Description

This PR updates io/module_write_netcdf.F90 to resolve RRFS hangs. It brings in the changes from develop branch.
See fv3atm develop branch PR #803
See ufs-weather-model issue ufs-community/ufs-weather-model#2174

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@DusanJovic-NOAA DusanJovic-NOAA changed the title Update io/module_write_netcdf.F90 to resolve RRFS hangs [production/RRFS.v1] Update io/module_write_netcdf.F90 to resolve RRFS hangs Mar 28, 2024
@DusanJovic-NOAA DusanJovic-NOAA changed the title [production/RRFS.v1] Update io/module_write_netcdf.F90 to resolve RRFS hangs [production/RRFS.v1] Update module_write_netcdf to avoid hangs in RRFS runs Mar 28, 2024
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Apr 2, 2024

@MatthewPyle-NOAA Tests are done at ufs-community/ufs-weather-model#2212. This pr can be merged with the approval.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit c01786d into NOAA-EMC:production/RRFS.v1 Apr 2, 2024
@DusanJovic-NOAA DusanJovic-NOAA deleted the rrfs_v1_write_netcdf_hangs branch April 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants