Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new global_nest_v1 suite and #715 #709

Merged
merged 34 commits into from
Nov 15, 2023

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Oct 15, 2023

Description

This is a suite of physics schemes nominally planned for the RRFS v2 upgrade. It's being used for the Water in the West project to simulate atmospheric rivers using a global model with a static nest. Hence "global_nest_v1."

PR #715 is included by request of the UFS code managers.

Issue(s) addressed

Testing

How were these changes tested?

The suite was tested with a simulation of a February 24, 2023 atmospheric river event.

What compilers / HPCs was it tested with?

Hera intel. FV3 nesting does not work with the gnu compiler or in debug mode due to known issues.

Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

Yes. There are two new tests:

  1. gnv1_c96_no_nest_debug - The standard C96 initial conditions used for most physics suites, configured to run global_nest_v1. This is run in debug mode for both compilers
  2. gnv1_nested - Run off of the HAFS global static nest test initial conditions, this tests the suite in a static nest.

Have the ufs-weather-model regression test been run? On what platform?

Hera and Jet.

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.

No. It adds two tests, but no tests change.

Please commit the regression test log files in your ufs-weather-model branch

Okay.

Dependencies

@SamuelTrahanNOAA SamuelTrahanNOAA changed the title new global_nest_v1 suite new global_nest_v1 suite and #714 Nov 8, 2023
@SamuelTrahanNOAA SamuelTrahanNOAA changed the title new global_nest_v1 suite and #714 new global_nest_v1 suite and #715 Nov 9, 2023
@grantfirl
Copy link
Collaborator

@SamuelTrahanNOAA
Copy link
Contributor Author

I'm pointing to the ufs/dev branch of ccpp-physics. This PR is ready for final review and merge.

@jkbk2004 jkbk2004 self-requested a review November 15, 2023 20:20
@jkbk2004 jkbk2004 merged commit 9ba5c5d into NOAA-EMC:develop Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants