Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quartet of bug fixes for: c3 scheme, quilting restart with 32-bit physics, and string length mismatch in dycore plus PR #705 and #699 #695

Merged
merged 32 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6930d6e
GFDL_atmos_cubed_sphere: consistent string lengths in array
SamuelTrahanNOAA Sep 3, 2023
0aee6e5
stop FV3_HRRR_c3 from crashing with gnu debug
SamuelTrahanNOAA Sep 6, 2023
59f7814
Update .gitmodules
DusanJovic-NOAA Sep 7, 2023
4a49820
bug fix from Dusan to recover_fields crash
SamuelTrahanNOAA Sep 7, 2023
b0f1fe9
Merge remote-tracking branch 'upstream/develop' into c3-pointer-fix
SamuelTrahanNOAA Sep 8, 2023
c6a04b0
rename GFDL_atmos_cubed_sphere branch
SamuelTrahanNOAA Sep 8, 2023
c4e0106
in dycore, initialize srf_wnd_var2 and tracers_var3 arrays
SamuelTrahanNOAA Sep 9, 2023
058d384
Write netcdf axis variables using the same real kind as data variables
DusanJovic-NOAA Sep 11, 2023
66e88f6
Merge remote-tracking branch 'origin/develop' into axis_type
DusanJovic-NOAA Sep 13, 2023
fbad839
"GF radar reflectivity, dust bug fix, C3 updates, more fluxes output"
haiqinli Sep 20, 2023
4c578bf
Fix race condition in GFS_phys_time_vary.fv3.F90 error detection
SamuelTrahanNOAA Sep 21, 2023
2959cab
More bug fixes to GFS_phys_time_vary.fv3.F90:
SamuelTrahanNOAA Sep 21, 2023
edc239b
initialize errmsg & errflg in noahmp_tables.f90
SamuelTrahanNOAA Sep 21, 2023
6017640
point to sam's branch
SamuelTrahanNOAA Sep 22, 2023
d6e8217
Merge remote-tracking branch 'origin/develop' into axis_type
DusanJovic-NOAA Sep 22, 2023
359eb55
only read h2odata, ozdata and noahmp table when they are needed
SamuelTrahanNOAA Sep 22, 2023
abd32a4
merge upstream
SamuelTrahanNOAA Sep 25, 2023
4021bb0
also update atmos_cubed_sphere
SamuelTrahanNOAA Sep 25, 2023
8c061a7
merge axis_type branch
SamuelTrahanNOAA Sep 25, 2023
3247fbc
merge other PR
SamuelTrahanNOAA Sep 25, 2023
9f59260
update atmos_cubed_sphere hash
SamuelTrahanNOAA Sep 26, 2023
c105d25
Merge remote-tracking branch 'upstream/develop' into bugfix/qr-c3-str…
SamuelTrahanNOAA Sep 26, 2023
4cd8a8f
remove all constant 3D variables from clm lake
SamuelTrahanNOAA Sep 27, 2023
03826c2
calculate clm lake constants only once per i loop
SamuelTrahanNOAA Sep 27, 2023
606fd4d
Merge branch 'NOAA-EMC:develop' into develop-radar
haiqinli Sep 28, 2023
b42dbfb
"point to ccpp-phyiscs updates"
haiqinli Sep 28, 2023
783630b
"point to the dimension fix of smc for dust emission"
haiqinli Sep 29, 2023
6aebe2b
more dycore bug fixes from GFDL_atmos_cubed_sphere PR 285
SamuelTrahanNOAA Sep 29, 2023
2a5c47e
merge #705
SamuelTrahanNOAA Sep 29, 2023
7530982
merge GFDL_atmos_cubed_sphere #276
SamuelTrahanNOAA Sep 29, 2023
c496c18
merge #699
SamuelTrahanNOAA Sep 29, 2023
3add3f6
point to upstream ccpp-physics and GFDL_atmos_cubed_sphere
SamuelTrahanNOAA Oct 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
[submodule "atmos_cubed_sphere"]
path = atmos_cubed_sphere
url = https://github.com/NOAA-GFDL/GFDL_atmos_cubed_sphere
branch = dev/emc
url = https://github.com/SamuelTrahanNOAA/GFDL_atmos_cubed_sphere
branch = bugfix/string-length-mismatch
[submodule "ccpp/framework"]
path = ccpp/framework
url = https://github.com/NCAR/ccpp-framework
branch = main
[submodule "ccpp/physics"]
path = ccpp/physics
url = https://github.com/ufs-community/ccpp-physics
branch = ufs/dev
url = https://github.com/SamuelTrahanNOAA/ccpp-physics
branch = c3-pointer-fix
[submodule "upp"]
path = upp
url = https://github.com/NOAA-EMC/UPP
Expand Down
2 changes: 1 addition & 1 deletion atmos_cubed_sphere
8 changes: 5 additions & 3 deletions io/module_wrt_grid_comp.F90
Original file line number Diff line number Diff line change
Expand Up @@ -2040,9 +2040,11 @@ subroutine wrt_run(wrt_comp, imp_state_write, exp_state_write,clock,rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return
endif

!recover fields from cartesian vector and sfc pressure
call recover_fields(file_bundle,rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return
if (fcstItemNameList(i)(1:8) /= "restart_") then
!recover fields from cartesian vector and sfc pressure
call recover_fields(file_bundle,rc)
if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return
end if

enddo
!
Expand Down