Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Convective Cloud (C3) scheme #657

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

haiqinli
Copy link
Contributor

@haiqinli haiqinli commented May 23, 2023

Description

  1. Name the new unified convective parameterization as "Community Convective Cloud (c3) parameterization";
  2. Update the aerosol-aware for GF;
  3. Merge the aerosol-aware and RRFS configuration from GF into C3;
  4. Make the closures as input namelist options for C3 and GF.

Testing

How were these changes tested? Yes
What compilers / HPCs was it tested with? Intel compiler on Hera
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
A new regression test run case of C3 convection should be added.
Have the ufs-weather-model regression test been run? On what platform? Yes, on Hera with Intel compiler.

  • Will the code updates change regression test baseline? If yes, why? Yes, the GF code was updated.

Dependencies

@lisa-bengtsson
Copy link
Contributor

@haiqinli I wonder if we should create a suite def file also for the RRFS configuration with C3? I made 2 for the global only (GFSv17 and GFSv17 coupled)

@haiqinli
Copy link
Contributor Author

@lisa-bengtsson Yes, I will add a HRRR_c3 suite for RRFS when I update this PR.

@haiqinli haiqinli closed this Jun 14, 2023
@haiqinli haiqinli deleted the develop-c3 branch June 14, 2023 22:10
@haiqinli haiqinli restored the develop-c3 branch June 14, 2023 22:11
@BrianCurtis-NOAA
Copy link
Collaborator

This needs to be reviewed before it can get into UFSWM commit queue.

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jun 20, 2023

@haiqinli @BrianCurtis-NOAA This PR also appears to depend on a CCPP changes but no information is provided here or at the UFS PR. Is there a CCPP PR associated with this ?

@haiqinli
Copy link
Contributor Author

@DeniseWorthen Yes, the associated CCPP PR is ufs-community/ccpp-physics#73. Thanks.

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jun 20, 2023

@haiqinli Please link that PR to this PR. Do that by editing your PR description with "- depends on" and the link to the CCPP PR.

In the above PR information you answered "no" to the question of whether this PR has dependencies.

@haiqinli
Copy link
Contributor Author

@DeniseWorthen The PR description has been updated accordingly. Thanks.

@grantfirl
Copy link
Collaborator

@haiqinli The physics PR was merged. Please revert .gitmodules and update the ccpp/physics submodule pointer in preparation for the fv3atm merge.

@jkbk2004
Copy link
Collaborator

@haiqinli ccpp pr was merged. Can you update ccpp/physics submodule pointer and revert change in gitmodules? Correct hash is ufs-community/ccpp-physics@427c77b

@jkbk2004
Copy link
Collaborator

@haiqinli can you resolve the conversation as well?

@haiqinli
Copy link
Contributor Author

@jkbk2004 @grantfirl Yes, I am working on it, and will update when it is done.

@haiqinli
Copy link
Contributor Author

I have some difficulties to do git push right now, and will continue to try it.

[Haiqin.Li@hfe04 fv3atm]$ git push https://github.com/haiqinli/fv3atm.git
fatal: unable to access 'https://github.com/haiqinli/fv3atm.git/': Could not resolve host: github.com; Unknown error

@haiqinli
Copy link
Contributor Author

@jkbk2004 @grantfirl Revert submodule pointer to ufs-community/ccpp-physics@427c77b is done. Thanks.

@jkbk2004 jkbk2004 merged commit 2363f5b into NOAA-EMC:develop Jun 26, 2023
@haiqinli haiqinli deleted the develop-c3 branch September 13, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants