-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bugfixes for CCPP v6 #541
Merged
junwang-noaa
merged 2 commits into
NOAA-EMC:develop
from
grantfirl:20220523_ccpp_v6_needs
May 25, 2022
Merged
Minor bugfixes for CCPP v6 #541
junwang-noaa
merged 2 commits into
NOAA-EMC:develop
from
grantfirl:20220523_ccpp_v6_needs
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
jkbk2004
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward and good. Sanity check also worked ok with cpld_debug_p8
MinsukJi-NOAA
approved these changes
May 25, 2022
DusanJovic-NOAA
approved these changes
May 25, 2022
@jkbk2004 CCPP submodule pointers have been updated and .gitmodules changes have been reverted. This is ready to merge. |
jkbk2004
pushed a commit
that referenced
this pull request
May 25, 2022
…535) * Add WoFS suite definition file for SRW v3 release * Set ccpp/physics submodule * Set pointer for ccpp/physics * Update ccpp_prebuild_config.py for one-to-one CCPP physics schemes/files (#519) * Move up to current CCPP public-v6 * Minor bugfixes for CCPP v6 (#541) * Point .gitmodules ccpp to 'main' branch Co-authored-by: Grant Firl <grant.firl@noaa.gov>
grantfirl
added a commit
to grantfirl/fv3atm
that referenced
this pull request
Jun 3, 2022
grantfirl
added a commit
to grantfirl/fv3atm
that referenced
this pull request
Jun 3, 2022
…OAA-EMC#535) * Add WoFS suite definition file for SRW v3 release * Set ccpp/physics submodule * Set pointer for ccpp/physics * Update ccpp_prebuild_config.py for one-to-one CCPP physics schemes/files (NOAA-EMC#519) * Move up to current CCPP public-v6 * Minor bugfixes for CCPP v6 (NOAA-EMC#541) * Point .gitmodules ccpp to 'main' branch Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates submodule pointers for CCPP physics and framework whose submodule PRs contains bugfixes for the issues listed below.
Issue(s) addressed
NCAR/ccpp-physics#927
NCAR/ccpp-framework#450
Testing
All tests in rt.conf pass with hera.intel with existing baselines.
Dependencies
NCAR/ccpp-physics#924
NCAR/ccpp-framework#451