Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfixes for CCPP v6 #541

Merged
merged 2 commits into from
May 25, 2022

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented May 23, 2022

Description

This pull request updates submodule pointers for CCPP physics and framework whose submodule PRs contains bugfixes for the issues listed below.

Issue(s) addressed

NCAR/ccpp-physics#927
NCAR/ccpp-framework#450

Testing

All tests in rt.conf pass with hera.intel with existing baselines.

Dependencies

NCAR/ccpp-physics#924
NCAR/ccpp-framework#451

Copy link
Collaborator

@jkbk2004 jkbk2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and good. Sanity check also worked ok with cpld_debug_p8

@grantfirl
Copy link
Collaborator Author

@jkbk2004 CCPP submodule pointers have been updated and .gitmodules changes have been reverted. This is ready to merge.

@junwang-noaa junwang-noaa merged commit a41a3de into NOAA-EMC:develop May 25, 2022
jkbk2004 pushed a commit that referenced this pull request May 25, 2022
…535)

* Add WoFS suite definition file for SRW v3 release

* Set ccpp/physics submodule

* Set pointer for ccpp/physics

* Update ccpp_prebuild_config.py for one-to-one CCPP physics schemes/files (#519)

* Move up to current CCPP public-v6

* Minor bugfixes for CCPP v6 (#541)

* Point .gitmodules ccpp to 'main' branch

Co-authored-by: Grant Firl <grant.firl@noaa.gov>
grantfirl added a commit to grantfirl/fv3atm that referenced this pull request Jun 3, 2022
grantfirl added a commit to grantfirl/fv3atm that referenced this pull request Jun 3, 2022
…OAA-EMC#535)

* Add WoFS suite definition file for SRW v3 release

* Set ccpp/physics submodule

* Set pointer for ccpp/physics

* Update ccpp_prebuild_config.py for one-to-one CCPP physics schemes/files (NOAA-EMC#519)

* Move up to current CCPP public-v6

* Minor bugfixes for CCPP v6 (NOAA-EMC#541)

* Point .gitmodules ccpp to 'main' branch

Co-authored-by: Grant Firl <grant.firl@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants