-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninitialized min_rand variable in Thompson MP when using SPP #516
Changes from all commits
45a9e9b
4992045
ed166d7
ddd27eb
5ada959
6fcdc04
c9cde94
b459cfa
a4aee16
9fdf4c0
41f5189
74e3f71
bdb6366
776adc2
a115b5e
62e7b4c
c74ea44
ef82808
aeccbce
175d46d
fc28d29
b9781c7
cd07f75
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
+21 −7 | physics/module_mp_thompson.F90 | |
+13 −3 | physics/mp_thompson.F90 | |
+31 −1 | physics/mp_thompson.meta |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -109,7 +109,7 @@ subroutine stochastic_physics_wrapper (GFS_Control, GFS_Data, Atm_block, ierr) | |
GFS_Control%input_nml_file, GFS_Control%fn_nml, GFS_Control%nlunit, xlon, xlat, GFS_Control%do_sppt, GFS_Control%do_shum, & | ||
GFS_Control%do_skeb, GFS_Control%lndp_type, GFS_Control%n_var_lndp, GFS_Control%use_zmtnblck, GFS_Control%skeb_npass, & | ||
GFS_Control%lndp_var_list, GFS_Control%lndp_prt_list, & | ||
GFS_Control%n_var_spp, GFS_Control%spp_var_list, GFS_Control%spp_prt_list, GFS_Control%do_spp, & | ||
GFS_Control%n_var_spp, GFS_Control%spp_var_list, GFS_Control%spp_prt_list, GFS_Control%spp_stddev_cutoff, GFS_Control%do_spp, & | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This has a different order than what is in stochastic_physics/stochastic_physcs.F90 in stochastic_physics.F90: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JeffBeck-NOAA would you please reply to Phil? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like in stochastic_physics.F90, it has been changed to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @pjpegion, @junwang-noaa, @ChunxiZhang-NOAA, yes, this problem was fixed. |
||
GFS_Control%ak, GFS_Control%bk, nthreads, GFS_Control%master, GFS_Control%communicator, ierr) | ||
if (ierr/=0) then | ||
write(6,*) 'call to init_stochastic_physics failed' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffBeck-NOAA I think that the following should fix the GNU issue that was reported:
For each SPP variable that is conditionally allocated in GFS_typedefs.F90, (spp_prt_list, spp_stddev_cutoff, spp_var_list), please add the following metadata attribute
active = (do_stochastically_perturbed_parameterizations)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grantfirl! This fixed the problem! I ended up having to apply it to spp_prt_list, spp_var_list, and spp_stddev_cutoff.