Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NoahMP restart fix and a standalone fv3 P7 CCPP suite file #391

Merged
merged 6 commits into from
Sep 24, 2021

Conversation

junwang-noaa
Copy link
Collaborator

@junwang-noaa junwang-noaa commented Sep 21, 2021

Description

In this PR, an fix in CCPP PR will fix the NoahMP restart issue in configuration P7 coupled tests. Also a standalone fv3 P7 CCPP suite file is also added to enable the standalone atmosphere test with P7 physics configurations.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

This fix has been tested in coupled test PR #765 on hera with C96mx100, C192mx0.5 and C384mx0.25 coupled tests

Dependencies

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should remove the commented out line in surface_composits.

@junwang-noaa
Copy link
Collaborator Author

@DusanJovic-NOAA would you please review?

@climbfuji
Copy link
Collaborator

ccpp-physics hash is correct, ready to merge

@junwang-noaa junwang-noaa merged commit d77f748 into NOAA-EMC:develop Sep 24, 2021
@junwang-noaa junwang-noaa deleted the noahmp_rstfix branch October 20, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants