Convert real(kind_phys) vegetation, slope and soil type arrays into integer arrays without affecting input/output files #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y interstitial arrays
…types before/after surface physics
… be used in the _init phases
14 tasks
climbfuji
requested review from
SMoorthi-emc,
DusanJovic-NOAA and
junwang-noaa
climbfuji
changed the title
…etation_soil_slope_type_integer
…etation_soil_slope_type_integer
…etation_soil_slope_type_integer
…etation_soil_slope_type_integer
…etation_soil_slope_type_integer
climbfuji
commented
Sep 30, 2021
| nb = Atm_block%blkno(ii,jj) | ||
| ix = Atm_block%ixp(ii,jj) | ||
| if (Diag(idx)%data(nb)%var21(ix) /= 0) var2(i,j) = Diag(idx)%data(nb)%var2(ix)*lcnvfac | ||
| call store_data(Diag(idx)%id, var2, Time, idx, Diag(idx)%intpl_method, Diag(idx)%name) |
There was a problem hiding this comment.
This GitHub diff view is confusing. The only thing that changed was adding the int_or_real: if case and move the existing code into the else block.
There was a problem hiding this comment.
Maybe in the future we need to consider outputting those fields as integer too.
There was a problem hiding this comment.
Yes, that would be nice, but it will require changes to the pre- and post-processing chain.
…etation_soil_slope_type_integer
junwang-noaa
approved these changes
Oct 1, 2021
DusanJovic-NOAA
approved these changes
Oct 4, 2021
|
This PR is ready to merge, ccpp-physics hash is up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the real vegetation, slope and soil type arrays and replaces them with the existing (interstitial) "integer" arrays (these become persistent). Additional
_savevariables are added as required for obtaining b4b identical output (see NCAR/ccpp-physics#730).The approach taken here was to take the conversion from integer to real for writing the data to disk to the latest point possible, and to convert back from real to integer when reading from disk. This ensures that there are zero changes to upstream and downstream processes. It should also be noted that the I/O layer currently does not support writing/reading integer data and that, if changes to the input/output files are preferred in a follow-up PR, additional development will be necessary.
Issue(s) addressed
Testing
For regression testing, see ufs-community/ufs-weather-model#804
Dependencies
NCAR/ccpp-physics#730
#388
ufs-community/ufs-weather-model#804