-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to tsfcl required when cplflx=true for restart comparison tests #105
Comments
The IPD regression tests will be dropped in the next few weeks and the IPD development will be frozen very soon except for urgent bug fixes related to the GFSv16 implementation. The corresponding CCPP code is in https://github.com/NCAR/ccpp-physics/blob/master/physics/GFS_surface_composites.F90 - please let me know if you need further information for making the changes there. |
Thanks Dom. The IPD change is in the FV3 branch I will be using for my PR for the CMEPS name changes which is why I created the issue to reference. For CCPP, is the equivalent change here by inserting if(Model%cplflx)tsfcl = tsfc_ocn(i) and similarly for the ice covered areas? |
Yes, this looks about right to me. |
I've been able to test this fix now on Cheyenne and it does pass our restart reproducibility test for tsfcl in the fv3 surface restart files. |
Testing Flake model with HRRR and GSD_v0 suites.
…velop_20211019 Update gsl/develop from develop 2021/10/19
Adding Issue Templates to Repository
When cplflx is true, the values of tsfcl in the FV3 restart files fail the regression test comparisons because of values for tsfcl over ocean and ice. The tsfcl values over land are identical (when using CMEPS as the mediator). For IPD, these changes are proposed at LN 2069 and at LN 2077.
Equivalent changes need to be made on the CCPP side.
The text was updated successfully, but these errors were encountered: