Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize cpl_scalars when created #1274

Conversation

DeniseWorthen
Copy link
Contributor

Pull Request Summary

For dev/ufs-weather-model, initializes the scalar field when created.

Description

Issue(s) addressed

Commit Message

Initialize the scalar field when created

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DeniseWorthen!

@zach1221
Copy link

zach1221 commented Aug 5, 2024

@JessicaMeixner-NOAA testing is complete on WM PR 2370. Can you please merge this PR?

@JessicaMeixner-NOAA
Copy link
Collaborator

@MatthewMasarik-NOAA can you merge this PR?

@MatthewMasarik-NOAA MatthewMasarik-NOAA merged commit 7f548c7 into NOAA-EMC:dev/ufs-weather-model Aug 6, 2024
20 checks passed
sbanihash pushed a commit to sbanihash/WW3 that referenced this pull request Sep 12, 2024
sbanihash added a commit to sbanihash/WW3 that referenced this pull request Sep 13, 2024
* adding attribute for time0/timeN oevrwrite protection

* adding time0/timeN overwrite protection

* initialize cpl_scalars when created (NOAA-EMC#1274)

---------

Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants