Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timers and overwrite capability for mod_def timesteps to meshcap #1164

Conversation

DeniseWorthen
Copy link
Contributor

@DeniseWorthen DeniseWorthen commented Jan 10, 2024

Pull Request Summary

Adds run timers to the meshcap

Description

Adds generation of a timer log in the meshcap, which will report, for example, the time spent in modelAdvance as well as the time spent before starting the next Advance. The capability is added using a wrapper mod (mimicking the CICE wrapper mod) so that no additional ifdefs are required in the cap. The output generated in log.ww3.timer is

20210322   60000   21600 WW3 InitializeRealize time: 0.7798858
20210322   60000   21600 WW3 ModelAdvance time since last step:  4.489980
20210322   61200   22320 WW3 ModelAdvance time:  2.570183
20210322   61200   22320 WW3 ModelAdvance time since last step:  8.023816
20210322   62400   23040 WW3 ModelAdvance time:  1.164186

Also adds capability to over-write timesteps from the mod_def file with other values. See associated UWM ufs-community/ufs-weather-model#2086 for description of how this works.

Issue(s) addressed

Commit Message

add timer log functionality to meshcap

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Testing in UWM ufs-community/ufs-weather-model#2086 has no impact on baselines.

* mod_def with slow timesteps overwritten verifies against
run using mod_def containing the fast timesteps
* mod_def with slow timesteps overwritten reproduces on
restart
* unlike CICE, there is no CESM specific shr code used in WW3
@DeniseWorthen DeniseWorthen changed the title Add timers to meshcap and overwrite capability for mod_def timesteps Add timers and overwrite capability for mod_def timesteps to meshcap Jan 10, 2024
@MatthewMasarik-NOAA
Copy link
Collaborator

I will get these started as well!

Copy link
Collaborator

@MatthewMasarik-NOAA MatthewMasarik-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are only in the meshcap code, so standalone testing is not necessary. UFS-WM testing has confirmed that no RT baselines change.

Approved.

@DeniseWorthen
Copy link
Contributor Author

Combined with #1163; Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants