Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync the RRFS hotfix #967 and #968. #979

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Sync the RRFS hotfix #967 and #968. #979

merged 4 commits into from
Jun 18, 2024

Conversation

WenMeng-NOAA
Copy link
Collaborator

Sync the RRFS hotfix #967 and #968.

@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 17, 2024 that may be closed by this pull request
Sync the RRFS hotfix #967 and #968 in develop #980
Closed
@WenMeng-NOAA WenMeng-NOAA added RRFS Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Jun 18, 2024
@WenMeng-NOAA
Copy link
Collaborator Author

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There are baseline updated for fv3r, 3drtma and gfs in this PR. You may refer to my testing on Hera at /home/Wen.Meng/stmp2:

Wen.Meng@hfe07 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp   75 Jun 18 13:28 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  724 Jun 18 13:28 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1086 Jun 18 13:29 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  724 Jun 18 13:29 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1086 Jun 18 13:29 rtma_2023040400/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 3387 Jun 18 13:40 gfs.20190830/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 Wen.Meng stmp 3387 Jun 18 13:40 gfs.20190830_pe_test/gfs.t00z.master.grb2f006.diff

@FernandoAndrade-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. There are baseline updated for fv3r, 3drtma and gfs in this PR. You may refer to my testing on Hera at /home/Wen.Meng/stmp2:

Wen.Meng@hfe07 stmp2$ ls -ltr */*diff
-rw-r--r-- 1 Wen.Meng stmp   75 Jun 18 13:28 rap_2020072316_pe_test/WRFPRS.GrbF16.diff
-rw-r--r-- 1 Wen.Meng stmp  724 Jun 18 13:28 fv3r_2023062800/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1086 Jun 18 13:29 rtma_2023040400_pe_test/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp  724 Jun 18 13:29 fv3r_2023062800_pe_test/PRSLEV10.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 1086 Jun 18 13:29 rtma_2023040400/PRSLEV00.tm00.diff
-rw-r--r-- 1 Wen.Meng stmp 3387 Jun 18 13:40 gfs.20190830/gfs.t00z.master.grb2f006.diff
-rw-r--r-- 1 Wen.Meng stmp 3387 Jun 18 13:40 gfs.20190830_pe_test/gfs.t00z.master.grb2f006.diff

My Hera run looks to match with your results. Hercules is running into file generation issues right now likely due to the disk quota being exceeded, I'm rerunning elsewhere. I believe Orion is still being tested on 1.6.0 with a unified-env-rock9 path, however I don't believe that contains the required g2tmpl version at the moment.

EricJames-NOAA
EricJames-NOAA approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@EricJames-NOAA EricJames-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I tested the code for RRFS, and got consistent results with my previous tests. Thanks for working on this.

@SamuelTrahanNOAA SamuelTrahanNOAA mentioned this pull request Jun 18, 2024
Merged
@FernandoAndrade-NOAA
Copy link
Collaborator

Test results match on Hercules as well, @WenMeng-NOAA you may want to check in on Sam's comment within PR #974

@WenMeng-NOAA
Copy link
Collaborator Author

The UPP RTs were completed on WCOSS2. The baseline for gfs,fv3r and 3drtma will be recreated with this PR.

@WenMeng-NOAA
Copy link
Collaborator Author

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit d5a7944 into NOAA-EMC:develop Jun 18, 2024
4 of 5 checks passed
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Jun 18, 2024
Closed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/UPP that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
9669aba 
* origin/develop:
  Updates to support MPAS applications (RRFS and HFIP) (NOAA-EMC#1029)
  Add 6-hrly max winds at 10m to SFS (NOAA-EMC#1019)
  Update jet.lua (NOAA-EMC#1027)
  Updates to support UPP use with MPAS (NOAA-EMC#1018)
  [develop]: Turn on WARN_AS_ERROR for Doxygen Documentation Builds (NOAA-EMC#1023)
  Sample PR for testing (NOAA-EMC#1007)
  Enable template 4-49 to obtain aerosol ensemble information (NOAA-EMC#1011)
  Relocate gfs/gefs/sfs control files (NOAA-EMC#990)
  update g2tmp on aws to 1.12.0 (NOAA-EMC#996)
  [develop]: Update requirements files (NOAA-EMC#994)
  Bump zipp from 3.17.0 to 3.19.1 in /doc/UserGuide (NOAA-EMC#991)
  remove stack-python load for Gaea build (NOAA-EMC#993)
  Bump certifi from 2024.2.2 to 2024.7.4 in /doc/UserGuide (NOAA-EMC#988)
  [develop]: Add Doxygen variable definitions to modules (NOAA-EMC#965)
  Read bucket either as an integer or float (NOAA-EMC#984)
  Update Orion module file for Rocky 9 upgrade (NOAA-EMC#987)
  UPP bugfixes for inline post and g2tmpl 1.12.0 compatibility (and number concentration updates) (NOAA-EMC#974)
  Sync the RRFS hotfix NOAA-EMC#967 and NOAA-EMC#968. (NOAA-EMC#979)
  Bump urllib3 from 2.2.1 to 2.2.2 in /doc/UserGuide (NOAA-EMC#981)
  Fix for hydrostatic runs - write out Omega and HGT from model output (NOAA-EMC#959)
  Bump requests from 2.31.0 to 2.32.0 in /doc/UserGuide (NOAA-EMC#963)
  Correct rt.sh paths (NOAA-EMC#957)
  Updates to use GRIB2 template 4.9 for QPFFFG and QPFARI variables in RRFS (NOAA-EMC#929)
  Add hourly averaged smoke PM2.5 and dust PM10 (NOAA-EMC#917)
  Update Namelist documentation for all namelist options (NOAA-EMC#940)
  update gtg code revision to v.4.16.3 (NOAA-EMC#954)
  Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UserGuide (NOAA-EMC#953)
  Clean up labeling for 15-min accumulated fields (NOAA-EMC#948)
  Updates to the GSL exp1 ceiling diagnostic (NOAA-EMC#947)
  Additional RT log information (NOAA-EMC#941)
  add cmake load to modulefile/gaea.lua (NOAA-EMC#945)
  RRFS updates (NOAA-EMC#938)
  add module for AWS (NOAA-EMC#934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJames-NOAA EricJames-NOAA EricJames-NOAA approved these changes

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

Assignees
No one assigned
Labels
Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync the RRFS hotfix #967 and #968 in develop
3 participants
@WenMeng-NOAA @FernandoAndrade-NOAA @EricJames-NOAA